Conversation
|
Images are ready for the commit at 6fc0fc9. To use with deploy scripts, first |
|
@sachaudh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| case 'severity': { | ||
| return shouldKeepDiscoveredAtImageColumn; | ||
| return shouldKeepSeverity || shouldKeepDiscoveredAtImageColumn; |
There was a problem hiding this comment.
why are you checking for shouldKeepDiscoveredAtImageColumn to determine the visibility of severity?
There was a problem hiding this comment.
It seems like we use that to determine whether to show the severity column. If you git blame you can track it down to this PR https://github.com/stackrox/rox/pull/8080. It seems like he added it according to that PR. All I know is that we want to show the severity for the Image CVEs and Node CVEs tables so I'm adding that conditional logic to display it for those. I don't want to mess around too much with what's here right now since we will eventually make changes to VM soon. If you want to dig into why it was added, maybe you can ask Gorman for clarification.
Description
This change ensures that we show the severity column in the Image and Node CVEs tables
Checklist
Testing Performed