Skip to content

Re-org migration conversion tool#3272

Merged
c-du merged 1 commit intomasterfrom
cong/convert
Oct 3, 2022
Merged

Re-org migration conversion tool#3272
c-du merged 1 commit intomasterfrom
cong/convert

Conversation

@c-du
Copy link
Contributor

@c-du c-du commented Sep 30, 2022

Description

Re-org the conversion tool to separate the test from the tool.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@ghost
Copy link

ghost commented Oct 1, 2022

Images are ready for the commit at 0a5ddb9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-196-g0a5ddb99bd.

Copy link
Contributor

@dashrews78 dashrews78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-du c-du merged commit c34baaf into master Oct 3, 2022
@c-du c-du deleted the cong/convert branch October 3, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants