ROX-13722: Readd nodeID to NodeInventory proto#4483
Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
8f73b48 to
f562c16
Compare
|
Images are ready for the commit at f562c16. To use with deploy scripts, first |
vikin91
commented
Jan 20, 2023
Comment on lines
+87
to
+89
| string node_id = 1; | ||
| string node_name = 2; | ||
| google.protobuf.Timestamp scan_time = 3; |
Contributor
Author
There was a problem hiding this comment.
No need for backwards compatibility here as this object is fully protected by the feature flag and has not been used by our customers before.
Contributor
Author
|
/test all |
5 tasks
Contributor
Author
|
/test gke-postgres-nongroovy-e2e-tests |
This was referenced Jan 20, 2023
md2119
approved these changes
Jan 20, 2023
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR was created as a split from #4430 in order to make the change easier to review.
This PR is meant to replace #3757 - as we will not attach NodeInventory to Node anymore, we need to change the NodeInventory so that it contains the information we will need in Central.
Here, we readd the
nodeIDfield toNodeInventoryas this field will be needed to uniquely identify the Node that the NodeInventory belongs to. TheNodeInventory.NodeIDwill be filled by Sensor in another PR.Note that by abandoning #3757 and following #4430 we DO NOT:
anymore.
I also renamed central pipeline for handling Node Inventories from
nodescanv2tonodeinventory.Checklist
Not apply
Testing Performed