Skip to content

[ROX-12943,-12975,-13722] Send NodeInventory as a separate message between Sensor and Central#4430

Closed
vikin91 wants to merge 8 commits intomasterfrom
piotr/ROX-13722-alternative
Closed

[ROX-12943,-12975,-13722] Send NodeInventory as a separate message between Sensor and Central#4430
vikin91 wants to merge 8 commits intomasterfrom
piotr/ROX-13722-alternative

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Jan 17, 2023

Description

This PR is an alternative implementation to #3757

This draft contains also #3940 and #3892

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vikin91
Copy link
Contributor Author

vikin91 commented Jan 17, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@vikin91 vikin91 changed the title Readd node_id to NodeInventory Send NodeInventory as a separate message between Sensor and Central Jan 17, 2023
@vikin91 vikin91 changed the title Send NodeInventory as a separate message between Sensor and Central [ROX-12943,-12975,-13722] Send NodeInventory as a separate message between Sensor and Central Jan 17, 2023
@github-actions github-actions bot added the ci-all-qa-tests Tells CI to run all API tests (not just BAT). label Jan 18, 2023
@vikin91
Copy link
Contributor Author

vikin91 commented Jan 19, 2023

/test all

@vikin91
Copy link
Contributor Author

vikin91 commented Jan 30, 2023

Closing in favor of #4492 #4484 #4483

@vikin91 vikin91 closed this Jan 30, 2023
@vikin91 vikin91 deleted the piotr/ROX-13722-alternative branch January 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant