ROX-14427: set PSPs for CI to false for k8s version 1.25 and higher#4488
Merged
johannes94 merged 13 commits intomasterfrom Jan 25, 2023
Merged
ROX-14427: set PSPs for CI to false for k8s version 1.25 and higher#4488johannes94 merged 13 commits intomasterfrom
johannes94 merged 13 commits intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test all |
|
Images are ready for the commit at 2483ea2. To use with deploy scripts, first |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
Contributor
Author
|
/test osd-gcp-qa-e2e-tests |
janisz
approved these changes
Jan 24, 2023
Contributor
|
hi @johannes94 I added the all label and kicked off some more tests. I feel like those PSPs were required for some tests but this will give enough coverage to see. |
Contributor
|
/test |
|
@gavin-stackrox: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
/test openshift-newest-qa-e2e-tests |
Contributor
|
/retest |
Contributor
Author
|
Thanks @gavin-stackrox, looks to me like all tests are green, I'll merge it. |
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 10, 2023
…4488) * set POD_SECURITY_POLICIES based on kubernetes version * set POD_SECURITY_POLICIES when true aswell
1 task
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 11, 2023
…4488) * set POD_SECURITY_POLICIES based on kubernetes version * set POD_SECURITY_POLICIES when true aswell
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 11, 2023
…4488) * set POD_SECURITY_POLICIES based on kubernetes version * set POD_SECURITY_POLICIES when true aswell
1 task
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 14, 2023
…4488) * set POD_SECURITY_POLICIES based on kubernetes version * set POD_SECURITY_POLICIES when true aswell
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 14, 2023
…4488) * set POD_SECURITY_POLICIES based on kubernetes version * set POD_SECURITY_POLICIES when true aswell
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've had CI Failures like this, because the bundle installation method tries to install a PodSecurityPolicy for central by default if the env variable
POD_SECURITY_POLICIESis not set or set totrue. PodSecurityPolicy was removed from Kubernetes 1.25 and upwards, which is why the test setup is failing.This PR changes the deploy scripts to query the Kubernetes server version and set
POD_SECURITY_POLICIESto false if it detects a version >= 1.25.Checklist
[ ] Unit test and regression tests added[ ] Evaluated and added CHANGELOG entry if required[ ] Determined and documented upgrade steps[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
Tested with commenting
/test osd-gcp-qa-e2e-testsIn addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.