Skip to content

ROX-14973: Various fixes for release-3.73#4829

Merged
gavin-stackrox merged 7 commits intorelease-3.73from
gavin/patches-for-3-73
Feb 14, 2023
Merged

ROX-14973: Various fixes for release-3.73#4829
gavin-stackrox merged 7 commits intorelease-3.73from
gavin/patches-for-3-73

Conversation

@gavin-stackrox
Copy link
Contributor

@gavin-stackrox gavin-stackrox commented Feb 10, 2023 •
edited
Loading

Description

WIP.

Picked so far

1e0fd6f Drop PodSecurityPolicy from errors files. (#4774)
eb1b45f Start using the batch/v1 api for CronJobs (#3854)
5e1595c ROX-14485: update monitoring psp (#4655)
f5baf26 ROX-14427: set PSPs for CI to false for k8s version 1.25 and higher (#4488)
42719ea ROX-12856: roxctl: Make sure that PSPs are not rendered for deployment bundles (#3230)

Checklist

  • Investigated and inspected CI test results

Testing Performed

CI is sufficient

@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 10, 2023

/test

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

@gavin-stackrox: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test gke-nongroovy-e2e-tests
  • /test gke-postgres-qa-e2e-tests
  • /test gke-qa-e2e-tests
  • /test gke-ui-e2e-tests
  • /test gke-upgrade-tests
  • /test go-postgres-tests
  • /test go-unit-tests
  • /test go-unit-tests-release
  • /test grouped-static-checks
  • /test images
  • /test integration-unit-tests
  • /test local-roxctl-tests
  • /test mitre-bundles-checks
  • /test openshift-newest-operator-e2e-tests
  • /test openshift-newest-qa-e2e-tests
  • /test openshift-oldest-operator-e2e-tests
  • /test openshift-oldest-qa-e2e-tests
  • /test openshift-penult-operator-e2e-tests
  • /test openshift-penultimate-qa-e2e-tests
  • /test policy-checks
  • /test push-images
  • /test shell-unit-tests
  • /test stackrox_branding-images
  • /test stackrox_branding-push-images
  • /test style-checks
  • /test ui-unit-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-stackrox-stackrox-release-3.73-gke-nongroovy-e2e-tests
  • pull-ci-stackrox-stackrox-release-3.73-gke-postgres-qa-e2e-tests
  • pull-ci-stackrox-stackrox-release-3.73-gke-qa-e2e-tests
  • pull-ci-stackrox-stackrox-release-3.73-gke-ui-e2e-tests
  • pull-ci-stackrox-stackrox-release-3.73-gke-upgrade-tests
  • pull-ci-stackrox-stackrox-release-3.73-go-postgres-tests
  • pull-ci-stackrox-stackrox-release-3.73-go-unit-tests
  • pull-ci-stackrox-stackrox-release-3.73-go-unit-tests-release
  • pull-ci-stackrox-stackrox-release-3.73-grouped-static-checks
  • pull-ci-stackrox-stackrox-release-3.73-images
  • pull-ci-stackrox-stackrox-release-3.73-integration-unit-tests
  • pull-ci-stackrox-stackrox-release-3.73-local-roxctl-tests
  • pull-ci-stackrox-stackrox-release-3.73-mitre-bundles-checks
  • pull-ci-stackrox-stackrox-release-3.73-policy-checks
  • pull-ci-stackrox-stackrox-release-3.73-push-images
  • pull-ci-stackrox-stackrox-release-3.73-shell-unit-tests
  • pull-ci-stackrox-stackrox-release-3.73-stackrox_branding-images
  • pull-ci-stackrox-stackrox-release-3.73-stackrox_branding-push-images
  • pull-ci-stackrox-stackrox-release-3.73-style-checks
  • pull-ci-stackrox-stackrox-release-3.73-ui-unit-tests
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 10, 2023

/test openshift-newest-operator-e2e-tests
/test openshift-newest-qa-e2e-tests
/test openshift-oldest-operator-e2e-tests
/test openshift-oldest-qa-e2e-tests
/test openshift-penult-operator-e2e-tests
/test openshift-penultimate-qa-e2e-tests

mtesseract and others added 4 commits February 11, 2023 00:13
@mtesseract @gavin-stackrox
ROX-12856: roxctl: Make sure that PSPs are not rendered for deploymen…
edc44d3 
…t bundles (#3230)

Make sure that auto-sensing for PSPs is disabled when rendering deployment bundles.
Fix PSP logic in local deployment script.
@johannes94 @gavin-stackrox
ROX-14427: set PSPs for CI to false for k8s version 1.25 and higher (#…
b6cdcbb 
…4488)

* set POD_SECURITY_POLICIES based on kubernetes version

* set POD_SECURITY_POLICIES when true aswell
@Maddosaurus @gavin-stackrox
ROX-14485: update monitoring psp (#4655)
4ee5d5d
@Molter73 @gavin-stackrox
Start using the batch/v1 api for CronJobs (#3854)
b3425f5
@robbycochran
Copy link
Contributor

robbycochran commented Feb 11, 2023

Do we also need #4813 ?

@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 11, 2023

Whatabout #3787 that was on Jouko's 3.72 PR #4790

@ghost
Copy link

ghost commented Feb 11, 2023 •
edited by ghost
Loading

Images are ready for the commit at 59068a3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.2-8-g59068a37a8.

@robbycochran
Copy link
Contributor

robbycochran commented Feb 11, 2023

#3787

That's already on 3.73, but we will need it for 3.72.

@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 11, 2023

/test openshift-newest-operator-e2e-tests
/test openshift-newest-qa-e2e-tests
/test openshift-oldest-operator-e2e-tests
/test openshift-oldest-qa-e2e-tests
/test openshift-penult-operator-e2e-tests
/test openshift-penultimate-qa-e2e-tests

@robbycochran robbycochran added this to the 3.73.3-rc.1 milestone Feb 11, 2023
@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 11, 2023

/test openshift-newest-operator-e2e-tests
/test openshift-newest-qa-e2e-tests
/test openshift-oldest-operator-e2e-tests
/test openshift-oldest-qa-e2e-tests
/test openshift-penult-operator-e2e-tests
/test openshift-penultimate-qa-e2e-tests

@gavin-stackrox gavin-stackrox changed the title WIP: Various fixes for release-3.73 Various fixes for release-3.73 Feb 11, 2023
@msugakov
Copy link
Contributor

msugakov commented Feb 13, 2023 •
edited
Loading

@gavin-stackrox I order to fix grouped-static-checks failures, we need this file https://github.com/stackrox/stackrox/pull/3820/files#diff-4771170f9cb1ab90b7940d157dccf8aae343b2b5fe5070f8cd8bdd4fde2aafc4

You can get it via

git co ce14d08a24250612ba4d66fd723f83d998c0c569 -- central/deployment/store/postgres/gen.go

See the context in https://srox.slack.com/archives/CMH5M8MHN/p1676290246758339

Also, this one #4837 should help deal with stringer issues.

@msugakov msugakov changed the title Various fixes for release-3.73 ROX-14973: Various fixes for release-3.73 Feb 13, 2023
@msugakov msugakov mentioned this pull request Feb 13, 2023
Closed
2 tasks
@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 14, 2023

@gavin-stackrox I order to fix grouped-static-checks failures, we need this file https://github.com/stackrox/stackrox/pull/3820/files#diff-4771170f9cb1ab90b7940d157dccf8aae343b2b5fe5070f8cd8bdd4fde2aafc4

You can get it via

git co ce14d08a24250612ba4d66fd723f83d998c0c569 -- central/deployment/store/postgres/gen.go

This did not work for me. And I could not find a way to include a single file change from a commit. So I manually went with c9d879b.

Also, this one #4837 should help deal with stringer issues.

Picked.

@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 14, 2023

/test openshift-newest-operator-e2e-tests
/test openshift-newest-qa-e2e-tests
/test openshift-oldest-operator-e2e-tests
/test openshift-oldest-qa-e2e-tests
/test openshift-penult-operator-e2e-tests
/test openshift-penultimate-qa-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

@gavin-stackrox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-ui-e2e-tests 59068a3 link true /test gke-ui-e2e-tests
ci/prow/openshift-oldest-qa-e2e-tests 59068a3 link true /test openshift-oldest-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gavin-stackrox
Copy link
Contributor Author

gavin-stackrox commented Feb 14, 2023

Merging. The 'oldest' test failure looks like a cluster flake.

@gavin-stackrox gavin-stackrox merged commit cb7c268 into release-3.73 Feb 14, 2023
@gavin-stackrox gavin-stackrox deleted the gavin/patches-for-3-73 branch February 14, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msugakov msugakov msugakov approved these changes

Assignees

No one assigned

Labels

area/central area/operator area/sensor

Projects

None yet

Milestone

3.73.3-rc.1

Development

Successfully merging this pull request may close these issues.

8 participants

@gavin-stackrox @robbycochran @msugakov @mtesseract @johannes94 @Maddosaurus @Molter73 @porridge