Skip to content

Include .gotools in the $PATH for go code generation#4837

Merged
msugakov merged 1 commit intomasterfrom
misha/demystery-stringer
Feb 13, 2023
Merged

Include .gotools in the $PATH for go code generation#4837
msugakov merged 1 commit intomasterfrom
misha/demystery-stringer

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Feb 13, 2023 •
edited
Loading

Description

This should help with stringer problems. At least it does solve it for my local problems.

Locally I've been seeing

central/graphql/resolvers/active_state.go
stringer -type=ActiveStateEnum
stringer: internal error: package "context" without types was imported from "github.com/stackrox/rox/central/graphql/resolvers"
central/graphql/resolvers/active_state.go:10: running "stringer": exit status 1

After some googling, that seems to happen because older stringer gets picked up. The obvious hunch is that stringer installed via go-tool is not visible during Go code generation.

Context: https://srox.slack.com/archives/CELUQKESC/p1674834470778089

Checklist

  • Investigated and inspected CI test results

None of these:

  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

  • No problems locally after the fix.
  • grouped-static-checks and Style / check-generated-files should remain green.

@msugakov
Include .gotools in the $PATH for go code generation
005f960 
This should help with `stringer` problems. At least it does solve it
for my local problems.
@ghost
Copy link

ghost commented Feb 13, 2023

Images are ready for the commit at 005f960.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.74.x-94-g005f9609ba.

@msugakov msugakov mentioned this pull request Feb 13, 2023
Merged
1 task
@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2023

@msugakov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openshift-newest-qa-e2e-tests 005f960 link false /test openshift-newest-qa-e2e-tests
ci/prow/openshift-oldest-qa-e2e-tests 005f960 link false /test openshift-oldest-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msugakov msugakov merged commit e2ea730 into master Feb 13, 2023
@msugakov msugakov deleted the misha/demystery-stringer branch February 13, 2023 17:44
gavin-stackrox pushed a commit that referenced this pull request Feb 14, 2023
@msugakov @gavin-stackrox
Include .gotools in the $PATH for go code generation (#4837)
59068a3
gavin-stackrox pushed a commit that referenced this pull request Feb 14, 2023
@msugakov @gavin-stackrox
Include .gotools in the $PATH for go code generation (#4837)
cb7c268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@porridge porridge Awaiting requested review from porridge

@gavin-stackrox gavin-stackrox Awaiting requested review from gavin-stackrox

@vikin91 vikin91 Awaiting requested review from vikin91

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msugakov @janisz