Skip to content

ROX-15812: Propagate $POD_SECURITY_POLICIES to roxctl when installing sensor.#5149

Merged
porridge merged 1 commit intomasterfrom
porridge/ROX-15812-fix
Mar 9, 2023
Merged

ROX-15812: Propagate $POD_SECURITY_POLICIES to roxctl when installing sensor.#5149
porridge merged 1 commit intomasterfrom
porridge/ROX-15812-fix

Conversation

@porridge
Copy link
Contributor

@porridge porridge commented Mar 8, 2023 •
edited
Loading

Description

Looks like this was missed in #3230

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

CI should be sufficient. Let me figure out how to run this on recent k8s...
/test help

@porridge porridge requested a review from gavin-stackrox March 8, 2023 11:39
@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2023

@porridge: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test shell-unit-tests

The following commands are available to trigger optional jobs:

  • /test aro-qa-e2e-tests
  • /test eks-qa-e2e-tests
  • /test gke-kernel-qa-e2e-tests
  • /test gke-nongroovy-e2e-tests
  • /test gke-postgres-nongroovy-e2e-tests
  • /test gke-postgres-qa-e2e-tests
  • /test gke-postgres-scale-tests
  • /test gke-postgres-ui-e2e-tests
  • /test gke-postgres-upgrade-tests
  • /test gke-qa-e2e-tests
  • /test gke-race-condition-qa-e2e-tests
  • /test gke-scale-tests
  • /test gke-ui-e2e-tests
  • /test gke-upgrade-tests
  • /test gke-version-compatibility-tests
  • /test ocp-4-11-operator-e2e-tests
  • /test ocp-4-11-qa-e2e-tests
  • /test ocp-4-12-operator-e2e-tests
  • /test ocp-4-12-qa-e2e-tests
  • /test ocp-4-12-ui-e2e-tests
  • /test ocp-4-6-operator-e2e-tests
  • /test ocp-4-6-qa-e2e-tests
  • /test ocp-4-6-ui-e2e-tests
  • /test ocp-4-8-operator-e2e-tests
  • /test ocp-4-8-qa-e2e-tests
  • /test ocp-next-operator-e2e-tests
  • /test ocp-next-qa-e2e-tests
  • /test ocp-next-ui-e2e-tests
  • /test osd-aws-qa-e2e-tests
  • /test osd-gcp-qa-e2e-tests
  • /test rosa-qa-e2e-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-stackrox-stackrox-master-gke-nongroovy-e2e-tests
  • pull-ci-stackrox-stackrox-master-gke-postgres-nongroovy-e2e-tests
  • pull-ci-stackrox-stackrox-master-gke-postgres-qa-e2e-tests
  • pull-ci-stackrox-stackrox-master-gke-qa-e2e-tests
  • pull-ci-stackrox-stackrox-master-ocp-4-12-operator-e2e-tests
  • pull-ci-stackrox-stackrox-master-ocp-4-12-qa-e2e-tests
  • pull-ci-stackrox-stackrox-master-ocp-4-8-operator-e2e-tests
  • pull-ci-stackrox-stackrox-master-ocp-4-8-qa-e2e-tests
  • pull-ci-stackrox-stackrox-master-shell-unit-tests
Details

In response to this:

Description

Looks like this was missed in #3230

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

CI should be sufficient. Let me figure out how to run this on recent k8s...
/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@porridge
Copy link
Contributor Author

porridge commented Mar 8, 2023

/test ocp-next-qa-e2e-tests
But I vaguely remember that ocp jobs use the operator to install? 🤔
How can I verify this @gavin-stackrox ?

@ghost
Copy link

ghost commented Mar 8, 2023

Images are ready for the commit at 4855b6a.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.74.x-308-g4855b6ad75.

@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2023

@porridge: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-next-qa-e2e-tests 4855b6a link false /test ocp-next-qa-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests 4855b6a link false /test ocp-4-12-operator-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@porridge porridge enabled auto-merge (squash) March 8, 2023 17:07
@porridge porridge disabled auto-merge March 8, 2023 17:07
@porridge porridge enabled auto-merge (squash) March 8, 2023 17:08
@porridge porridge merged commit af9fbed into master Mar 9, 2023
@porridge porridge deleted the porridge/ROX-15812-fix branch March 9, 2023 12:32
@porridge porridge mentioned this pull request Mar 10, 2023
Closed
vikin91 pushed a commit that referenced this pull request Mar 13, 2023
@porridge @vikin91
ROX-15812: Propagate $POD_SECURITY_POLICIES to roxctl when instal…
210af98 
…ling sensor. (#5149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gavin-stackrox gavin-stackrox gavin-stackrox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@porridge @gavin-stackrox