Skip to content

ROX-12856: roxctl: Make sure that PSPs are not rendered for deployment bundles#3230

Merged
mtesseract merged 6 commits intomasterfrom
mc/roxctl-psp-fix
Oct 4, 2022
Merged

ROX-12856: roxctl: Make sure that PSPs are not rendered for deployment bundles#3230
mtesseract merged 6 commits intomasterfrom
mc/roxctl-psp-fix

Conversation

@mtesseract
Copy link
Contributor

Description

See https://issues.redhat.com/browse/ROX-12856.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@ghost
Copy link

ghost commented Sep 28, 2022

Images are ready for the commit at eea3b79.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-212-geea3b79783.

Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing comments!
Let's see what CI tests would show us.

@mtesseract mtesseract merged commit 3beea72 into master Oct 4, 2022
@mtesseract mtesseract deleted the mc/roxctl-psp-fix branch October 4, 2022 11:27
@theencee theencee modified the milestones: 3.71.2-rc.2, 3.72.1-rc.2 Oct 10, 2022
@github-actions
Copy link
Contributor

Merge commit has been cherry-picked to branch release-3.72.

ghost pushed a commit that referenced this pull request Oct 10, 2022
…t bundles (#3230)

Make sure that auto-sensing for PSPs is disabled when rendering deployment bundles.
Fix PSP logic in local deployment script.

(cherry picked from commit 3beea72)
@Maddosaurus Maddosaurus mentioned this pull request Feb 1, 2023
5 tasks
gavin-stackrox pushed a commit that referenced this pull request Feb 10, 2023
…t bundles (#3230)

Make sure that auto-sensing for PSPs is disabled when rendering deployment bundles.
Fix PSP logic in local deployment script.
gavin-stackrox pushed a commit that referenced this pull request Feb 11, 2023
…t bundles (#3230)

Make sure that auto-sensing for PSPs is disabled when rendering deployment bundles.
Fix PSP logic in local deployment script.
gavin-stackrox pushed a commit that referenced this pull request Feb 11, 2023
…t bundles (#3230)

Make sure that auto-sensing for PSPs is disabled when rendering deployment bundles.
Fix PSP logic in local deployment script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants