ROX-9280: Scan image with local Scanner#517
Merged
Conversation
5 tasks
connorgorman
approved these changes
Feb 23, 2022
SimonBaeumer
approved these changes
Feb 23, 2022
RTann
added a commit
that referenced
this pull request
Feb 24, 2022
RTann
added a commit
that referenced
this pull request
Feb 24, 2022
RTann
added a commit
that referenced
this pull request
Feb 24, 2022
RTann
added a commit
that referenced
this pull request
Apr 6, 2022
RTann
added a commit
that referenced
this pull request
Apr 6, 2022
RTann
added a commit
that referenced
this pull request
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #416. This PR implements the Sensor-side functionality of Scanning:
Checklist
[ ] Determined and documented upgrade stepsTesting Performed
The full pipeline is still incomplete, so there are no E2E tests at this time, and there is no particular part that would benefit from a unit test.
Manual testing:
ROX_SKIP_PEER_VALIDATION=truein Scanner and wait for it to come back up.ROX_LOCAL_IMAGE_SCANNING=true,ROX_SCANNER_GRPC_ENDPOINT=scanner.stackrox.svc.8443,LOGLEVEL=debugin Sensor.Retrieved metadata for image <image> in namespace <namespace>: <metadata>andGot image components from local Scanner for image <image> in namespace <namespace>.Example deployment YAML for OpenShift 4.x: