Conversation
3 tasks
|
Tag for build #218810 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.68.x-220-g01e05390fd'📦 You can also generate an installation bundle with: docker run -i --rm stackrox/main:3.68.x-220-g01e05390fd central generate interactive > bundle.zip🕹️ A |
viswajithiii
approved these changes
Feb 16, 2022
Contributor
viswajithiii
left a comment
There was a problem hiding this comment.
LGTM modulo comment
| for _, integration := range integrations { | ||
| clusterSet := set.NewStringSet(integration.GetClusters()...) | ||
| if len(request.GetCluster()) != 0 && !clusterSet.Contains(request.GetCluster()) { | ||
| if request.GetCluster() != "" { |
Contributor
There was a problem hiding this comment.
Wouldn't we also want to remove this parameter from this proto as well (and add a changelog entry saying so)?
Contributor
Author
There was a problem hiding this comment.
The autogenerated registries still do this. Does it work? I don't think so, but I'm thinking I should save that for when we cleanup autogenerated registries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We don't use this field. Let's just remove it.
Checklist
[ ] Unit test and regression tests added[ ] Evaluated and added CHANGELOG entry if required[ ] Determined and documented upgrade stepsTesting Performed
CI