Skip to content

ROX-9545: Retry request to quay in vulns check#785

Closed
janisz wants to merge 3 commits intomasterfrom
tj/ROX-9545_retry_quay
Closed

ROX-9545: Retry request to quay in vulns check#785
janisz wants to merge 3 commits intomasterfrom
tj/ROX-9545_retry_quay

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Mar 2, 2022

Description

--retry <num> If a transient error is returned when curl tries to perform a transfer, it will retry this number of times before giving up. Setting the number to 0 makes curl do no retries (which is the default). Transient error means either: a timeout, an FTP 4xx response code or an HTTP 408, 429, 500, 502, 503 or 504 response code.

When curl is about to retry a transfer, it will first wait one second and then for all forthcoming retries it will double the waiting time until it reaches 10 minutes which then will be the delay between the rest of the retries. By using --retry-delay you disable this exponential backoff algorithm. See also --retry-max-time to limit the total time allowed for retries.

Since curl 7.66.0, curl will comply with the Retry-After: response header if one was present to know when to issue the next retry.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps

If any of these don't apply, please comment below.

Testing Performed

CI

@ghost
Copy link
Copy Markdown

ghost commented Mar 2, 2022

Tag for build #267822 is 3.68.x-323-g602de5dffd.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.68.x-323-g602de5dffd'

📦 You can also generate an installation bundle with:

docker run -i --rm stackrox/main:3.68.x-323-g602de5dffd central generate interactive > bundle.zip

🕹️ A roxctl binary artifact can be downloaded from CircleCI.

Copy link
Copy Markdown
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the condition that you create a hack or long term solution to make CI test the change.

@janisz janisz force-pushed the tj/ROX-9545_retry_quay branch 3 times, most recently from 1122acb to 1179290 Compare March 3, 2022 11:51
@janisz janisz added ci-all-qa-tests Tells CI to run all API tests (not just BAT). ci-no-api-tests labels Mar 3, 2022
@janisz janisz force-pushed the tj/ROX-9545_retry_quay branch 2 times, most recently from e6ef4ca to 276d2f2 Compare March 3, 2022 13:18
@janisz janisz force-pushed the tj/ROX-9545_retry_quay branch from 276d2f2 to 602de5d Compare March 3, 2022 13:22
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 3, 2022

Looks like there is a problem with quay since its constantly failing with 500.
I created an issue https://redhat.service-now.com/surl.do?n=INC2122640

@janisz janisz closed this Mar 3, 2022
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 4, 2022

I closed this PR and then pushed with force so I could not reopen it.
Here it is #825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-all-qa-tests Tells CI to run all API tests (not just BAT). team/merlin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants