Skip to content

ROX-9545: Use manifest API instead of deprecated image API in quay.io#825

Merged
janisz merged 5 commits intomasterfrom
tj/ROX-9545_retry_quay
Mar 4, 2022
Merged

ROX-9545: Use manifest API instead of deprecated image API in quay.io#825
janisz merged 5 commits intomasterfrom
tj/ROX-9545_retry_quay

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Mar 4, 2022 •
edited
Loading

Description

From quay.io support:

The image API is deprecated and cannot be used anymore. Quay.io now internally functions only on manifests.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps

If any of these don't apply, please comment below.

Testing Performed

https://app.circleci.com/pipelines/github/stackrox/stackrox/6129/workflows/323f9000-92cb-4c73-83d3-bdfc93306b30/jobs/274209

@janisz janisz marked this pull request as draft March 4, 2022 14:27
@janisz janisz force-pushed the tj/ROX-9545_retry_quay branch 4 times, most recently from e7325cf to 1908abe Compare March 4, 2022 14:56
@ghost
Copy link
Copy Markdown

ghost commented Mar 4, 2022 •
edited by ghost
Loading

Tag for build #274726 is 3.68.x-325-g3522170e9b.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.68.x-325-g3522170e9b'

📦 You can also generate an installation bundle with:

docker run -i --rm stackrox/main:3.68.x-325-g3522170e9b central generate interactive > bundle.zip

🕹️ A roxctl binary artifact can be downloaded from CircleCI.

@janisz janisz force-pushed the tj/ROX-9545_retry_quay branch 2 times, most recently from 4f82574 to 0a4818d Compare March 4, 2022 15:09
@janisz janisz force-pushed the tj/ROX-9545_retry_quay branch from 0a4818d to 73ed2ce Compare March 4, 2022 15:14
@janisz janisz requested a review from gavin-stackrox March 4, 2022 15:21
@janisz janisz marked this pull request as ready for review March 4, 2022 15:23
@janisz janisz changed the title WIP ROX-9545: retry: quay ROX-9545: retry: quay Mar 4, 2022
@janisz janisz mentioned this pull request Mar 4, 2022
Closed
4 tasks
@janisz janisz changed the title ROX-9545: retry: quay ROX-9545: Use manifest API instead of deprecated image API in quay.io Mar 4, 2022
gavin-stackrox
gavin-stackrox approved these changes Mar 4, 2022
View reviewed changes
release/scripts/vuln_check.sh
@@ -24,7 +24,7 @@ function compare_fixable_vulns {
if [[ "$(jq -r '.is_manifest_list' <<<"$img_data")" == "true" ]]; then
Copy link
Copy Markdown
Contributor

@gavin-stackrox gavin-stackrox Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the echo on line 22. echo "Fetching current image data ...

@janisz janisz enabled auto-merge (squash) March 4, 2022 16:26
@janisz janisz merged commit d82bac5 into master Mar 4, 2022
@janisz janisz deleted the tj/ROX-9545_retry_quay branch March 4, 2022 16:44
parametalol pushed a commit that referenced this pull request Mar 9, 2022
@janisz
ROX-9545: Use manifest API instead of deprecated image API in quay.io (…
4d8a2e8 
…#825)
@parametalol parametalol mentioned this pull request Mar 11, 2022
Merged
RTann pushed a commit that referenced this pull request Apr 6, 2022
@janisz
ROX-9545: Use manifest API instead of deprecated image API in quay.io (…
6ce5b44 
…#825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gavin-stackrox gavin-stackrox gavin-stackrox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team/merlin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janisz @gavin-stackrox