Skip to content

feat(node:process): add version and versions.node#493

Merged
pi0 merged 5 commits intomainfrom
vicb/version
Apr 1, 2025
Merged

feat(node:process): add version and versions.node#493
pi0 merged 5 commits intomainfrom
vicb/version

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Apr 1, 2025

A few packages read the node version, i.e. const [major, minor, patch] = process.versions.node.split;.

For example Jose v4 (see opennextjs/opennextjs-cloudflare#333 (comment)). With older Node versions, Jose will try to access util.deepClone so it has to be a recent Node release.

/cc @petebacondarwin @mhart

@pi0
Copy link
Member

pi0 commented Apr 1, 2025

Can you help to make an automated script to sync nvmrc to a generated .ts file? 🙏🏼

@vicb
Copy link
Contributor Author

vicb commented Apr 1, 2025

Can you help to make an automated script to sync nvmrc to a generated .ts file? 🙏🏼

Great idea!
I have added that to the build.ts script, let me know if this looks ok

@vicb vicb changed the title process: return Node verion process: return Node version Apr 1, 2025
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx!

@pi0 pi0 changed the title process: return Node version feat(node:process): add version and versions.node Apr 1, 2025
@pi0 pi0 merged commit fbf145d into main Apr 1, 2025
2 checks passed
@pi0 pi0 deleted the vicb/version branch April 1, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants