Skip to content

feat(node:process): add version and versions.node #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 5 commits into from
Apr 1, 2025
+15 −2
Merged

feat(node:process): add version and versions.node #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afcea64
process: return Node verion
vicb Apr 1, 2025
a2dce12
fixup! extract NODE_VERSION from .nvmrc
vicb Apr 1, 2025
53722c1
fixup! do not ignore node-version.ts
vicb Apr 1, 2025
0df7498
chore: apply automated updates
autofix-ci[bot] Apr 1, 2025
9ae1056
fixup! generate formatted code
vicb Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ console.log(`Bundling src/index...`);
await rolldownBuild(rootDir, "src/index.ts", "dist/index.mjs");

console.log(`Building src/runtime...`);
await generateNodeVersion(rootDir, "src/runtime/node/internal/process");
await transformDir(rootDir, "src/runtime", "dist/runtime");

console.log(`Build finished in ${Date.now() - start}ms`);
Expand Down Expand Up @@ -206,3 +207,11 @@ function resolvePath(id: string, parent: string) {
Error.captureStackTrace?.(error, resolvePath);
throw error;
}

async function generateNodeVersion(rootDir: string, outPath: string) {
const m = (await readFile(join(rootDir, ".nvmrc"), "utf8")).match(/(?<version>\d+\.\d+\.\d+)/);
if (!m?.groups?.version) {
throw new Error('.nvrmc does not contain a valid Node version');
}
await writeFile(join(rootDir, outPath, 'node-version.ts'), `// Extracted from .nvmrc\nexport const NODE_VERSION = ${JSON.stringify(m.groups.version)};\n`, 'utf8');
}
2 changes: 2 additions & 0 deletions src/runtime/node/internal/process/node-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// Extracted from .nvmrc
export const NODE_VERSION = "22.14.0";
6 changes: 4 additions & 2 deletions src/runtime/node/internal/process/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import {
notImplemented,
createNotImplementedError,
} from "../../../_internal/utils.ts";
// node-version.ts is generated at build time
import { NODE_VERSION } from "./node-version.ts";

export class Process extends EventEmitter implements NodeJS.Process {
env: NodeJS.ProcessEnv;
Expand Down Expand Up @@ -92,11 +94,11 @@ export class Process extends EventEmitter implements NodeJS.Process {
ppid: number = 100;

get version() {
return "";
return `v${NODE_VERSION}`;
}

get versions() {
return {} as NodeJS.Process["versions"];
return { node: NODE_VERSION } as NodeJS.Process["versions"];
}

get allowedNodeEnvironmentFlags() {
Expand Down