Skip to content

ROX-26974: Add failed clusters field to the report snapshot status#13361

Merged
lvalerom merged 1 commit intomasterfrom
lvm/rox-26974-add-failed-clusters-to-the-api-response
May 14, 2025
Merged

ROX-26974: Add failed clusters field to the report snapshot status#13361
lvalerom merged 1 commit intomasterfrom
lvm/rox-26974-add-failed-clusters-to-the-api-response

Conversation

@lvalerom
Copy link
Contributor

@lvalerom lvalerom commented Nov 18, 2024 •
edited
Loading

Description

  • Adds a list of failed clusters (failed_clusters ) to the ComplianceReportStatus proto.
  • Adds new PARTIAL_FAILURE state to the ComplianceReportStatus proto.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 18, 2024 •
edited
Loading

Images are ready for the commit at d54ead3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-660-gd54ead363a.

@codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.12%. Comparing base (6ce16b8) to head (d54ead3).
Report is 39 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #13361   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files        2558     2558           
  Lines      187891   187891           
=======================================
+ Hits        92293    92310   +17     
+ Misses      88318    88303   -15     
+ Partials     7280     7278    -2
Flag Coverage Δ
go-unit-tests 49.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sachaudh
sachaudh approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@sachaudh sachaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachaudh
Copy link
Contributor

sachaudh commented Dec 18, 2024

@lvalerom Is this good to merge? Do you need someone from backend to review this too?

@lvalerom lvalerom force-pushed the lvm/rox-26974-add-failed-clusters-to-the-api-response branch from 891941d to e47be13 Compare May 6, 2025 10:04
This was referenced May 6, 2025
Merged
Merged
@lvalerom lvalerom force-pushed the lvm/rox-26974-add-failed-clusters-to-the-api-response branch from e47be13 to d0223ad Compare May 8, 2025 10:54
@lvalerom lvalerom marked this pull request as ready for review May 9, 2025 10:20
sourcery-ai[bot]
sourcery-ai bot reviewed May 9, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lvalerom - I've reviewed your changes - here's some feedback:

  • Define the precise conditions for using the PARTIAL_FAILURE state, particularly its interaction with existing report statuses and the new failed_clusters list.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lvalerom lvalerom requested review from dashrews78, mtodor and vikin91 May 9, 2025 10:33
@lvalerom
Copy link
Contributor Author

lvalerom commented May 9, 2025

@lvalerom Is this good to merge? Do you need someone from backend to review this too?

@sachaudh now that it has been tested in #15232, it is ready to be merged. I'll still give the chance for someone from the BE to review though.

@lvalerom lvalerom force-pushed the lvm/rox-26974-add-failed-clusters-to-the-api-response branch from d0223ad to d54ead3 Compare May 9, 2025 10:46
vikin91
vikin91 approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left one suggestion to make it more future-proof

@lvalerom lvalerom merged commit 56814f6 into master May 14, 2025
98 checks passed
@lvalerom lvalerom deleted the lvm/rox-26974-add-failed-clusters-to-the-api-response branch May 14, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikin91 vikin91 vikin91 approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@sachaudh sachaudh sachaudh approved these changes

@mtodor mtodor Awaiting requested review from mtodor

@dashrews78 dashrews78 Awaiting requested review from dashrews78

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lvalerom @rhacs-bot @sachaudh @vikin91