ROX-27490: Add failed clusters to storage protos#15201
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
9 tasks
Contributor
|
Images are ready for the commit at 9d8eb96. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15201 +/- ##
==========================================
- Coverage 49.12% 49.11% -0.01%
==========================================
Files 2568 2568
Lines 188577 188577
==========================================
- Hits 92630 92619 -11
- Misses 88641 88649 +8
- Partials 7306 7309 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 7, 2025
e47be13 to
d0223ad
Compare
13bef89 to
d4d7962
Compare
d0223ad to
d54ead3
Compare
d4d7962 to
4f402ec
Compare
9 tasks
Base automatically changed from
lvm/rox-26974-add-failed-clusters-to-the-api-response
to
master
May 14, 2025 15:50
4f402ec to
e9a3923
Compare
e9a3923 to
9d8eb96
Compare
Contributor
Author
|
@vikin91 I changed |
Contributor
Great! Thanks for addressing that :) |
ksurabhi91
pushed a commit
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Storage proto changes to add the information of failed clusters when a report is generated.
User-facing documentation
Testing and quality
Automated testing
How I validated my change