Skip to content

ROX-26974: Populate API fields#15232

Merged
lvalerom merged 2 commits intomasterfrom
lvm/rox-26974-populate-api-fields
May 28, 2025
Merged

ROX-26974: Populate API fields#15232
lvalerom merged 2 commits intomasterfrom
lvm/rox-26974-populate-api-fields

Conversation

@lvalerom
Copy link
Contributor

@lvalerom lvalerom commented May 8, 2025 •
edited
Loading

Description

This PR populates the v2 protos with the FailedClusters.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • Manual testing:
    • Deploy in two clusters with Compliance Operator
    • Create a Scan Schedule with both cluster
    • Make one of the scans fail mid scan (e.g. disconnect sensor from central)
    • Query central API and observe the status is set to PARTIAL ERROR

@openshift-ci
Copy link

openshift-ci bot commented May 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 8, 2025 •
edited
Loading

Images are ready for the commit at 044d0d4.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-835-g044d0d4619.

@codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.26%. Comparing base (37eeeb6) to head (044d0d4).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15232   +/-   ##
=======================================
  Coverage   49.25%   49.26%           
=======================================
  Files        2581     2581           
  Lines      189326   189342   +16     
=======================================
+ Hits        93251    93272   +21     
+ Misses      88735    88731    -4     
+ Partials     7340     7339    -1
Flag Coverage Δ
go-unit-tests 49.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lvalerom lvalerom force-pushed the lvm/rox-27490-handle-failed-clusters branch 2 times, most recently from 9d74dba to 52127f9 Compare May 8, 2025 12:07
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch from fb3fc41 to 5fb0568 Compare May 8, 2025 12:09
@lvalerom lvalerom force-pushed the lvm/rox-27490-handle-failed-clusters branch from 52127f9 to de38c1c Compare May 8, 2025 12:18
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch 2 times, most recently from 1ee61f1 to 7ec9eaa Compare May 8, 2025 14:34
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch 3 times, most recently from 7ad1f48 to 7ec9eaa Compare May 8, 2025 16:27
This was referenced May 9, 2025
Closed
Merged
Merged
Merged
Merged
@lvalerom lvalerom force-pushed the lvm/rox-27490-handle-failed-clusters branch 2 times, most recently from 5a7115d to 7ecb259 Compare May 19, 2025 10:06
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch 2 times, most recently from 65fd879 to b7aafd2 Compare May 19, 2025 10:28
@lvalerom lvalerom force-pushed the lvm/rox-27490-handle-failed-clusters branch from 7ecb259 to 3b1318e Compare May 22, 2025 13:42
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch from b7aafd2 to 6da877f Compare May 26, 2025 15:25
@lvalerom lvalerom marked this pull request as ready for review May 26, 2025 15:29
@lvalerom lvalerom force-pushed the lvm/rox-27490-handle-failed-clusters branch from 3b1318e to 438ccf3 Compare May 26, 2025 16:42
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch from 6da877f to 4b0c8a3 Compare May 26, 2025 16:43
@lvalerom lvalerom requested review from mtodor and vikin91 May 27, 2025 13:03
@lvalerom lvalerom force-pushed the lvm/rox-27490-handle-failed-clusters branch from 91af2e4 to 9253ce9 Compare May 27, 2025 16:07
mtodor
mtodor reviewed May 27, 2025
View reviewed changes
mtodor
mtodor approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@mtodor mtodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to change to approve in the previous review. All my comments are not changing behaviour - they are all nitpicks.

@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch from 3f62977 to d3bdd09 Compare May 27, 2025 16:45
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch 2 times, most recently from 024867e to dfd2833 Compare May 28, 2025 10:56
Base automatically changed from lvm/rox-27490-handle-failed-clusters to master May 28, 2025 13:59
@lvalerom lvalerom force-pushed the lvm/rox-26974-populate-api-fields branch from dfd2833 to 044d0d4 Compare May 28, 2025 14:21
@openshift-ci
Copy link

openshift-ci bot commented May 28, 2025

@lvalerom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests 044d0d4 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lvalerom lvalerom merged commit 16f9d4f into master May 28, 2025
90 of 91 checks passed
@lvalerom lvalerom deleted the lvm/rox-26974-populate-api-fields branch May 28, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtodor mtodor mtodor approved these changes

@vikin91 vikin91 Awaiting requested review from vikin91

Assignees

No one assigned

Labels

area/central area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lvalerom @rhacs-bot @mtodor