Skip to content

fix(image): remove unused packages#14445

Closed
janisz wants to merge 5 commits intoremove_bzip2_lz4from
purge-package-management-with-deps
Closed

fix(image): remove unused packages#14445
janisz wants to merge 5 commits intoremove_bzip2_lz4from
purge-package-management-with-deps

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Feb 28, 2025 •
edited
Loading

Description

This PR removes unused packages such as USB support

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

@janisz janisz requested a review from a team as a code owner February 28, 2025 12:49
@github-actions github-actions bot added area/helm area/scanner konflux-build Run Konflux in PR. Push commit to trigger it. labels Feb 28, 2025
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Feb 28, 2025 •
edited
Loading

Images are ready for the commit at 102e2c2.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-146-g102e2c25b0.

@janisz janisz changed the title fix: remove pacakges with deps fix(image): remove pacakges with deps Feb 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (e08caef) to head (102e2c2).
Report is 115 commits behind head on remove_bzip2_lz4.

Additional details and impacted files 
@@                Coverage Diff                @@
##           remove_bzip2_lz4   #14445   +/-   ##
=================================================
  Coverage             49.11%   49.11%           
=================================================
  Files                  2522     2522           
  Lines                184227   184227           
=================================================
+ Hits                  90479    90483    +4     
+ Misses                86548    86544    -4     
  Partials               7200     7200
Flag Coverage Δ
go-unit-tests 49.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz janisz force-pushed the purge-package-management-with-deps branch 3 times, most recently from d5ad1a9 to 5286609 Compare February 28, 2025 16:07
@janisz janisz removed the konflux-build Run Konflux in PR. Push commit to trigger it. label Mar 3, 2025
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 3, 2025

/retest

@janisz janisz added the konflux-build Run Konflux in PR. Push commit to trigger it. label Mar 3, 2025
@janisz janisz requested a review from a team March 3, 2025 12:33
@janisz janisz force-pushed the purge-package-management-with-deps branch from 5286609 to bf1084d Compare March 3, 2025 16:24
janisz
janisz commented Mar 3, 2025
View reviewed changes
janisz
janisz commented Mar 3, 2025
View reviewed changes
janisz
janisz commented Mar 3, 2025
View reviewed changes
msugakov
msugakov requested changes Mar 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really worried that this gets approved and merged before the following is clarified.

I'm not 100% sure if we I can remove compression libs.

Therefore I block this review with the Request changes option.

If you'd like to reduce the size of the released images and are looking for something potentially more easily achievable, I'd suggest to look at https://issues.redhat.com/browse/ROX-28240

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 3, 2025 •
edited
Loading

If you'd like to reduce the size of the released images and are looking for something potentially more easily achievable

That's good point. Here I'd like to address CVE we find during release of 4.5 and 4.6 in libs that are not used and should be deleted with microdnf

@janisz janisz changed the title fix(image): remove pacakges with deps fix(image): remove unused packages Mar 4, 2025
@janisz
fix: remove pacakges with deps
102e2c2 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>

Apply suggestions from code review
@janisz janisz changed the base branch from master to remove_bzip2_lz4 March 4, 2025 14:37
@janisz janisz requested a review from a team as a code owner March 4, 2025 14:37
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 4, 2025

This change is part of the following stack:

Change managed by git-spice.

@janisz janisz force-pushed the purge-package-management-with-deps branch from 5c593f0 to 102e2c2 Compare March 4, 2025 14:37
This was referenced Mar 4, 2025
Closed
Merged
Closed
Merged
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 18, 2025

Closing as we will solve this issue by migration to ubi-micro instead of package pruning.

@janisz janisz closed this Mar 18, 2025
@janisz janisz mentioned this pull request Apr 3, 2025
Closed
@janisz janisz deleted the purge-package-management-with-deps branch September 16, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msugakov msugakov msugakov requested changes

Assignees

No one assigned

Labels

area/helm area/scanner konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janisz @rhacs-bot @msugakov