Skip to content

chore(image): remove packages with dependencies#14485

Closed
janisz wants to merge 2 commits intomasterfrom
remove_packages_with_deps
Closed

chore(image): remove packages with dependencies#14485
janisz wants to merge 2 commits intomasterfrom
remove_packages_with_deps

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Mar 4, 2025

Description

Currently we do remove package managers but without dependencies (--nodeps).
This PR forces removal with dependencies as they are not needed since package is removed.
This resulted in additional removal of libmodulemd which is not required since we remove
package manager.

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

@janisz janisz requested review from a team as code owners March 4, 2025 13:00
@janisz janisz requested a review from msugakov March 4, 2025 13:01
@github-actions github-actions bot added area/helm area/scanner konflux-build Run Konflux in PR. Push commit to trigger it. labels Mar 4, 2025
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 4, 2025 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@janisz janisz mentioned this pull request Mar 4, 2025
Closed
5 tasks
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 4, 2025 •
edited
Loading

Images are ready for the commit at 2f03a66.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-256-g2f03a6612c.

@janisz janisz mentioned this pull request Mar 4, 2025
Merged
5 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (e08caef) to head (8c0b578).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14485   +/-   ##
=======================================
  Coverage   49.11%   49.11%           
=======================================
  Files        2522     2522           
  Lines      184227   184227           
=======================================
+ Hits        90479    90481    +2     
+ Misses      86548    86546    -2     
  Partials     7200     7200
Flag Coverage Δ
go-unit-tests 49.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janisz janisz mentioned this pull request Mar 4, 2025
Merged
5 tasks
@janisz janisz changed the base branch from master to remove_bzip2_lz4 March 4, 2025 14:22
@janisz janisz force-pushed the remove_packages_with_deps branch from 05fd351 to 9e47f9f Compare March 4, 2025 14:22
@janisz janisz changed the base branch from remove_bzip2_lz4 to master March 4, 2025 14:29
@janisz janisz force-pushed the remove_packages_with_deps branch from 9e47f9f to 8c0b578 Compare March 4, 2025 14:29
@janisz janisz mentioned this pull request Mar 4, 2025
Closed
5 tasks
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 4, 2025

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests 8c0b578 link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-17-scanner-v4-install-tests 8c0b578 link false /test ocp-4-17-scanner-v4-install-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz janisz force-pushed the remove_packages_with_deps branch from 8c0b578 to 2f03a66 Compare March 18, 2025 12:08
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 18, 2025

Closing as we will solve this issue by migration to ubi-micro instead of package pruning.

@janisz janisz closed this Mar 18, 2025
@janisz janisz deleted the remove_packages_with_deps branch September 16, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msugakov msugakov Awaiting requested review from msugakov

Assignees

No one assigned

Labels

area/helm area/scanner konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janisz @rhacs-bot