chore(deps): remove unix utils from release image#14487
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Images are ready for the commit at 4259821. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14487 +/- ##
=======================================
Coverage 49.17% 49.17%
=======================================
Files 2532 2532
Lines 185508 185508
=======================================
+ Hits 91223 91229 +6
+ Misses 87047 87042 -5
+ Partials 7238 7237 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
porridge
left a comment
There was a problem hiding this comment.
I'm assuming the unit test failure is unrelated.
| microdnf -y upgrade --nobest && \ | ||
| rpm -i --nodeps /tmp/postgres-libs.rpm && \ | ||
| rpm -i --nodeps /tmp/postgres.rpm && \ | ||
| microdnf install --setopt=install_weak_deps=0 --nodocs -y lz4 bzip2 util-linux && \ |
There was a problem hiding this comment.
Besides other things, util-linux provides /usr/bin/kill and /usr/bin/more. I use them when debugging things in containers. What's the vision of all these change? Are we going to reduce the containers to scratch? I think we need to talk.
There was a problem hiding this comment.
@msugakov have you tried using ephemeral debug containers for such debugging? That's the suggested solution for reducing bloat yet allowing arbitrary debug tools..
There was a problem hiding this comment.
I think I tried that few years back and I did not understand how to use it.
Trying now on some demo cluster. Willing to connect to node scanner container (called node-inventory) in the collector pod and list processes. Here's what I observe:
$ kubectl --namespace stackrox debug -it collector-lxdxb --image=registry.access.redhat.com/ubi9/ubi --target=node-inventory
$ cat /etc/system-release
Red Hat Enterprise Linux release 9.5 (Plow)
# this is from the debug container because node scanner is 8-based. I should see this instead:
# Red Hat Enterprise Linux release 8.10 (Ootpa)
$ ls /
afs bin boot dev etc home lib lib64 media mnt opt proc root run sbin srv sys tmp usr var
# nope, I should see the following:
# THIRD_PARTY_NOTICES entrypoint.sh import-additional-cas mnt root srv var
# bin etc lib opt run sys
# boot genesis_manifests.json lib64 proc save-dir-contents tmp
# cache home lost+found repo2cpe sbin trust-root-ca
# dev host media restore-all-dir-contents scanner usr
# I don't know where's everything.
$ ps
bash: ps: command not found
$ dnf install procps-ng
$ ps -ef
UID PID PPID C STIME TTY TIME CMD
root 68 0 0 19:18 pts/0 00:00:00 /bin/bash
root 112 68 0 19:24 pts/0 00:00:00 ps -ef
# No idea where to look for node scannerMaybe I'm missing something stupidly obvious but not sure what.
Did you have more success with the debug containers? I'd be happy to move this conversation to Slack if you prefer.
There was a problem hiding this comment.
No, sorry, I never actually tried it. I totally just blindly believed the "best thing since " hype 😅
There was a problem hiding this comment.
Maybe --target would help with the ps but no idea about the files...
There was a problem hiding this comment.
I used --target in my command.
There was a problem hiding this comment.
Oh, right, perhaps OpenShift's container runtime does not support this 🤷🏻
|
/retest |
1 similar comment
|
/retest |
msugakov
left a comment
There was a problem hiding this comment.
@janisz I think without the ci-all-qa-tests label not all Groovy tests run. I added the label. Please re-trigger Groovy and let's see whether the CI would still be happy.
Also, I'd ask you to check nightlies results after this PR (and the other #14489 too) gets merged to make sure there are no regressions caused by the changes. Deal?
Description
linux-utilswas added when we moved to ubi-minimal as it was required by e2e tests that useskillin main container.This need was removed when test was rewritten in go. So we can remove linux-utils.
Testing
Automated testing
How I validated my change
CI