Skip to content

ROX-29453: Inactive image retention setting 0 should never prune images#15469

Merged
sachaudh merged 1 commit intorelease-4.7from
backport-15444-to-release-4.7
May 29, 2025
Merged

ROX-29453: Inactive image retention setting 0 should never prune images#15469
sachaudh merged 1 commit intorelease-4.7from
backport-15444-to-release-4.7

Conversation

@rhacs-bot
Copy link
Contributor

Backport 62b9857 from #15444.

@github-actions github-actions bot added area/central backport PR to backport changes from master to release branch labels May 28, 2025
@rhacs-bot
Copy link
Contributor Author

Images are ready for the commit at 8efc299.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.3-1-g8efc299573.

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.17%. Comparing base (8d55e07) to head (8efc299).
Report is 1 commits behind head on release-4.7.

Files with missing lines Patch % Lines
central/pruning/pruning.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-4.7   #15469      +/-   ##
===============================================
- Coverage        49.17%   49.17%   -0.01%     
===============================================
  Files             2515     2515              
  Lines           182962   182966       +4     
===============================================
- Hits             89976    89968       -8     
- Misses           85846    85855       +9     
- Partials          7140     7143       +3     
Flag Coverage Δ
go-unit-tests 49.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sachaudh
Copy link
Contributor

/retest

@sachaudh sachaudh merged commit 218a94a into release-4.7 May 29, 2025
88 of 99 checks passed
@sachaudh sachaudh deleted the backport-15444-to-release-4.7 branch May 29, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/central backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants