Skip to content

ROX-29060: Add gauge metrics for collections used in enrichment#16140

Merged
vikin91 merged 3 commits intomasterfrom
piotr/ROX-29060-improvements-part-2
Aug 7, 2025
Merged

ROX-29060: Add gauge metrics for collections used in enrichment#16140
vikin91 merged 3 commits intomasterfrom
piotr/ROX-29060-improvements-part-2

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Jul 23, 2025

This PR was a part of a stack, so it misses the PR template.

Description

The PR includes the following:

  • Adds gauge metrics for the size of collections used in the enrichment, so that we can always see how long is a given slice/map
  • Fixes the log-rate-limiter issue (missed that in ROX-29060: Refactor network flow enrichment #15076)
  • Applies one tiny performance optimization when copying maps to a slice - this has been proposed by Cursor and benchmarked by me.

Testing

@vikin91
Copy link
Contributor Author

vikin91 commented Jul 23, 2025

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jul 23, 2025

Images are ready for the commit at bd314d6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-431-gbd314d65a1.

@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch 2 times, most recently from e04f905 to 5c6ab05 Compare July 24, 2025 09:42
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.11%. Comparing base (ea8a0da) to head (63d3c95).
⚠️ Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
sensor/common/networkflow/manager/manager_impl.go 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16140      +/-   ##
==========================================
- Coverage   49.12%   49.11%   -0.01%     
==========================================
  Files        2631     2631              
  Lines      194299   194395      +96     
==========================================
+ Hits        95440    95469      +29     
- Misses      91396    91463      +67     
  Partials     7463     7463              
Flag Coverage Δ
go-unit-tests 49.11% <92.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch 2 times, most recently from e30633e to 2a0a9bd Compare July 30, 2025 08:02
@vikin91 vikin91 force-pushed the piotr/ROX-29060-refactor-enrichment branch from da96bc3 to 7eb005c Compare August 5, 2025 14:59
@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch from 5c00962 to 5e2142a Compare August 6, 2025 07:52
Base automatically changed from piotr/ROX-29060-refactor-enrichment to master August 6, 2025 09:21
@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch from 5e2142a to 493cf94 Compare August 6, 2025 09:41
@vikin91 vikin91 changed the title ROX-29060: Further improvements ROX-29060: Add gauge metrics for the size of collections used in the enrichment Aug 6, 2025
@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch from dd7378c to b51d759 Compare August 6, 2025 09:51
@vikin91 vikin91 changed the title ROX-29060: Add gauge metrics for the size of collections used in the enrichment ROX-29060: Add gauge metrics for collections used in enrichment Aug 6, 2025
@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch from b51d759 to bd314d6 Compare August 6, 2025 10:02
@vikin91 vikin91 requested a review from rhybrillou August 6, 2025 10:08
@vikin91 vikin91 marked this pull request as ready for review August 6, 2025 10:08
@vikin91 vikin91 requested a review from a team as a code owner August 6, 2025 10:08
@vikin91 vikin91 added the auto-retest PRs with this label will be automatically retested if prow checks fails label Aug 6, 2025
@rhacs-bot
Copy link
Contributor

/retest

1 similar comment
@rhacs-bot
Copy link
Contributor

/retest

Copy link
Contributor

@rhybrillou rhybrillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Small file organization nit: I prefer when functions are defined below their callers

@vikin91
Copy link
Contributor Author

vikin91 commented Aug 6, 2025

LGTM

Small file organization nit: I prefer when functions are defined below their callers

Ack. Let me add it to my .cursorrules.
I will correct it in the next PR (or this one in case another push will be required).

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Aug 6, 2025

Images are ready for the commit at 63d3c95.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-433-g63d3c95b13.

@rhacs-bot
Copy link
Contributor

/retest

1 similar comment
@rhacs-bot
Copy link
Contributor

/retest

@vikin91 vikin91 merged commit cf8a91f into master Aug 7, 2025
89 checks passed
@vikin91 vikin91 deleted the piotr/ROX-29060-improvements-part-2 branch August 7, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sensor auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants