Skip to content

ROX-29060: Add grafana dashboards for enrichment#16151

Merged
vikin91 merged 14 commits intomasterfrom
piotr/ROX-29060-grafana-dashboards
Aug 14, 2025
Merged

ROX-29060: Add grafana dashboards for enrichment#16151
vikin91 merged 14 commits intomasterfrom
piotr/ROX-29060-grafana-dashboards

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Jul 24, 2025 •
edited
Loading

Add Grafana Dashboards for the metrics used in enrichment.

They look currently like this (fresh cluster):

Connections

Enrichment-of-Connections-Dashboards-Grafana-08-11-2025_10_51_AM

Endpoints

Enrichment-of-Endpoints-Dashboards-Grafana-08-11-2025_10_51_AM

@vikin91
Copy link
Contributor Author

vikin91 commented Jul 24, 2025 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vikin91 vikin91 mentioned this pull request Jul 24, 2025
Merged
12 tasks
@vikin91 vikin91 changed the base branch from piotr/ROX-29060-refactor-enrichment to piotr/ROX-29060-improvements-part-2 July 24, 2025 09:56
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from 93e5272 to 8a73c48 Compare July 24, 2025 09:56
@vikin91 vikin91 mentioned this pull request Jul 24, 2025
Merged
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jul 24, 2025 •
edited
Loading

Images are ready for the commit at 5e85194.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-460-g5e85194e1f.

@codecov
Copy link

codecov bot commented Jul 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.05%. Comparing base (cf8a91f) to head (5e85194).
⚠️ Report is 43 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16151      +/-   ##
==========================================
- Coverage   49.09%   49.05%   -0.05%     
==========================================
  Files        2631     2635       +4     
  Lines      194544   195367     +823     
==========================================
+ Hits        95508    95829     +321     
- Misses      91569    92040     +471     
- Partials     7467     7498      +31
Flag Coverage Δ
go-unit-tests 49.05% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch from 7dacd09 to e30633e Compare July 25, 2025 15:19
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from 81fa5e2 to e8d15c7 Compare July 25, 2025 15:20
@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch from e30633e to 2a0a9bd Compare July 30, 2025 08:02
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch 2 times, most recently from 54a1135 to eafc6e1 Compare July 30, 2025 16:11
@vikin91 vikin91 mentioned this pull request Jul 31, 2025
Closed
9 tasks
@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch from 5c00962 to 5e2142a Compare August 6, 2025 07:52
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from eafc6e1 to 06f5231 Compare August 6, 2025 07:52
@vikin91 vikin91 force-pushed the piotr/ROX-29060-improvements-part-2 branch 2 times, most recently from dd7378c to b51d759 Compare August 6, 2025 09:51
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from 06f5231 to f5802b3 Compare August 6, 2025 09:59
@vikin91 vikin91 changed the base branch from piotr/ROX-29060-improvements-part-2 to master August 6, 2025 09:59
@vikin91 vikin91 changed the base branch from master to piotr/ROX-29060-improvements-part-2 August 6, 2025 10:03
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from f5802b3 to cbcd895 Compare August 6, 2025 10:03
Base automatically changed from piotr/ROX-29060-improvements-part-2 to master August 7, 2025 06:51
@vikin91 vikin91 requested a review from rhybrillou August 11, 2025 08:53
@vikin91 vikin91 marked this pull request as ready for review August 11, 2025 08:53
rhybrillou
rhybrillou approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@rhybrillou rhybrillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Most of the comments are nitpicks.
Considerations for potential follow-up work:

  • create groups within the dashboard (I think the data for these is only loaded once they are expanded, which could improve the load time of the dashboard)
  • have consistent panel sizes (although panels in a row have consistent height, panel across rows have sizes that vary a bit)
  • make consistent use of time units or [$__rate_interval] across panels

vikin91 and others added 6 commits August 13, 2025 10:54
@vikin91 @rhybrillou
Apply suggestion from @rhybrillou
9bc8096 
Co-authored-by: Yann Brillouet <91869377+rhybrillou@users.noreply.github.com>
@vikin91 @rhybrillou
Use 1m instead of rate_interval
d9826c3 
Co-authored-by: Yann Brillouet <91869377+rhybrillou@users.noreply.github.com>
@vikin91 @rhybrillou
Fix selecting connections instead of endpoints.
877ea56 
Co-authored-by: Yann Brillouet <91869377+rhybrillou@users.noreply.github.com>
@vikin91
Fix all rate intervals to 1m
67f55f7
@vikin91
Remove groupping by checkRemoveResult
18c3df0
@vikin91
Simplify chart description
5e85194
@openshift-ci
Copy link

openshift-ci bot commented Aug 13, 2025 •
edited
Loading

@vikin91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests 5e85194 link false /test ocp-4-12-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vikin91
Copy link
Contributor Author

vikin91 commented Aug 13, 2025

/retest-required

@vikin91 vikin91 enabled auto-merge (squash) August 13, 2025 15:41
@vikin91
Copy link
Contributor Author

vikin91 commented Aug 14, 2025

/test gke-upgrade-tests

@vikin91 vikin91 merged commit 4310ed4 into master Aug 14, 2025
96 of 97 checks passed
@vikin91 vikin91 deleted the piotr/ROX-29060-grafana-dashboards branch August 14, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vikin91 @rhacs-bot @rhybrillou