Skip to content

ROX-30390: Leftovers from the prototype & code instrumentation#16238

Closed
vikin91 wants to merge 8 commits intomasterfrom
piotr/ROX-30390-updates-to-central
Closed

ROX-30390: Leftovers from the prototype & code instrumentation#16238
vikin91 wants to merge 8 commits intomasterfrom
piotr/ROX-30390-updates-to-central

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Jul 31, 2025 •
edited
Loading

Description

⚠️ DO NOT MERGE

This PR holds the tip of the PR stack and contains all code used in the prototyping phase that most probably should not be merged into master. In particular:

  • General benchmarking code
  • Metrics meant only for comparing the legacy implementation against the categorized implementation
  • The combined update computer that is a synthetic being created only to execute two other update computers in parallel

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Size of helper data structs

Base branch (no workload).

Note that the Legacy implementations will never use closed*Size, that is why they are all 0. However, it will store the last sent state - see enriched*LastSentState.

TODO

This PR.

Note that the Categorized implementations will never use enriched*LastSentState, that is why they are all 0. However, it will store all closed connections - see closedConnsSize.

# HELP rox_sensor_host_connections_collections_size_current Current size of given collection involved in enrichment
# TYPE rox_sensor_host_connections_collections_size_current gauge
rox_sensor_host_connections_collections_size_current{Name="activeConnections",Type="connections"} 0
rox_sensor_host_connections_collections_size_current{Name="activeEndpoints",Type="endpoints"} 0
rox_sensor_host_connections_collections_size_current{Name="closedConnsSize",Type="connections"} 16
rox_sensor_host_connections_collections_size_current{Name="connectionsInEnrichQueue",Type="connections"} 759
rox_sensor_host_connections_collections_size_current{Name="endpointsInEnrichQueue",Type="endpoints"} 0
rox_sensor_host_connections_collections_size_current{Name="enrichedConnectionsLastSentState",Type="connections"} 0
rox_sensor_host_connections_collections_size_current{Name="enrichedEndpointsLastSentState",Type="endpoints"} 0
rox_sensor_host_connections_collections_size_current{Name="enrichedProcessesLastSentState",Type="processes"} 0
``

@vikin91
Copy link
Contributor Author

vikin91 commented Jul 31, 2025 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 35c28a0 to 60d5adb Compare July 31, 2025 16:08
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jul 31, 2025 •
edited
Loading

Images are ready for the commit at 4863bbe.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-767-g4863bbeb02.

@codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 6.49351% with 144 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.94%. Comparing base (510074c) to head (4863bbe).
⚠️ Report is 107 commits behind head on master.

Files with missing lines Patch % Lines
...sor/common/networkflow/manager/manager_combined.go 0.00% 127 Missing ⚠️
sensor/common/networkflow/updatecomputer/legacy.go 0.00% 7 Missing ⚠️
...mon/networkflow/updatecomputer/transition_based.go 12.50% 7 Missing ⚠️
sensor/common/networkflow/manager/manager_impl.go 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16238      +/-   ##
==========================================
+ Coverage   48.80%   48.94%   +0.13%     
==========================================
  Files        2681     2692      +11     
  Lines      200443   201616    +1173     
==========================================
+ Hits        97824    98673     +849     
- Misses      95011    95291     +280     
- Partials     7608     7652      +44
Flag Coverage Δ
go-unit-tests 48.94% <6.49%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 84434bb to c23d11b Compare August 6, 2025 07:33
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from eafc6e1 to 06f5231 Compare August 6, 2025 07:52
This was referenced Aug 6, 2025
Merged
Merged
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from abff35a to 02331a4 Compare August 6, 2025 09:58
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from 06f5231 to f5802b3 Compare August 6, 2025 09:59
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch 2 times, most recently from a4c9698 to e011138 Compare August 6, 2025 10:01
@vikin91 vikin91 force-pushed the piotr/ROX-29060-grafana-dashboards branch from f5802b3 to cbcd895 Compare August 6, 2025 10:03
@vikin91 vikin91 changed the base branch from piotr/ROX-29060-grafana-dashboards to master August 6, 2025 10:03
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch 2 times, most recently from 927633c to 44fc457 Compare August 6, 2025 14:25
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 58aba7f to 5668728 Compare August 15, 2025 15:59
@vikin91 vikin91 added the ci-all-qa-tests Tells CI to run all API tests (not just BAT). label Aug 19, 2025
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 36b9a43 to 703e66e Compare August 19, 2025 09:04
@vikin91 vikin91 changed the base branch from master to piotr/ROX-30390-indicators August 19, 2025 09:58
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 703e66e to eaa9b45 Compare August 19, 2025 09:58
@vikin91 vikin91 mentioned this pull request Aug 19, 2025
Merged
9 tasks
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch 2 times, most recently from 704fe59 to 8569426 Compare August 19, 2025 10:21
@vikin91 vikin91 changed the base branch from piotr/ROX-30390-indicators to piotr/ROX-30390-update-computer August 19, 2025 15:31
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 95e2235 to 35cfa5e Compare August 19, 2025 15:31
@vikin91 vikin91 mentioned this pull request Aug 19, 2025
Merged
9 tasks
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from ac7ff37 to 3f9f4ca Compare September 1, 2025 15:09
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from fc34cbe to f334b70 Compare September 1, 2025 15:09
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from 3f9f4ca to 9b9dd17 Compare September 2, 2025 07:20
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from f334b70 to 1ac5d52 Compare September 2, 2025 07:20
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from 9b9dd17 to 140f9db Compare September 2, 2025 08:12
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 1ac5d52 to ccb518f Compare September 2, 2025 08:12
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from 140f9db to d9cb951 Compare September 2, 2025 08:25
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from ccb518f to 47765fe Compare September 2, 2025 08:25
@vikin91 vikin91 mentioned this pull request Sep 2, 2025
Merged
9 tasks
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from d9cb951 to c7cea83 Compare September 2, 2025 08:39
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 47765fe to 35b7587 Compare September 2, 2025 08:39
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from c7cea83 to 2dbc36b Compare September 2, 2025 09:04
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 35b7587 to 8f2fe5e Compare September 2, 2025 09:04
@vikin91 vikin91 mentioned this pull request Sep 2, 2025
Merged
9 tasks
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from 2dbc36b to 61244cc Compare September 2, 2025 09:30
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 8f2fe5e to f3ae7f0 Compare September 2, 2025 09:30
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from 61244cc to 79fd12e Compare September 2, 2025 10:27
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from f3ae7f0 to 0627fd1 Compare September 2, 2025 10:27
@vikin91 vikin91 force-pushed the piotr/ROX-30390-dont-queue-open-ee branch from c566f54 to a5e05d2 Compare September 3, 2025 07:53
@vikin91 vikin91 force-pushed the piotr/ROX-30390-updates-to-central branch from 0627fd1 to 3052e34 Compare September 3, 2025 07:53
@vikin91 vikin91 mentioned this pull request Sep 11, 2025
Merged
9 tasks
@vikin91
Copy link
Contributor Author

vikin91 commented Sep 23, 2025

Closing as this was never meant to be merged.
This is off-sync with the new patch from #16901
The performance of that impl will be compared by running two separate clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ai-review area/sensor do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vikin91 @rhacs-bot @janisz