ROX-30390: Prefactor: Extract indicators into pkg by vikin91 · Pull Request #16447 · stackrox/stackrox

vikin91 · 2025-08-19T09:58:17Z

Description

This is a pre-factoring step for the feature in #16238 (changing the way we calculate the updates to Central with the goal of reducing memory usage).

The indicators will get more functions in the later steps (computation of unique key using two methods), so I propose to separate them into a dedicated pkg.

No change in behavior is introduced in this PR.

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

How I validated my change

Unit tests in CI should be sufficient

openshift-ci · 2025-08-19T09:58:21Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

vikin91 · 2025-08-19T09:58:23Z

This change is part of the following stack:

ROX-30390: Prefactor: Extract indicators into pkg #16447 ◀
- ROX-30390: Extract Update Computer #16452
  - ROX-30390: Leftovers from the prototype & code instrumentation #16238

_{Change managed by git-spice.}

red-hat-konflux · 2025-08-19T09:58:24Z

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
central-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
main-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
operator-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
operator-bundle-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-collector	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
roxctl-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n body.pull_request.labels.exists(l, l.name == \"konflux-build\")\n )\n)\n" failed to evaluate: no such key: pull_request`

rhacs-bot · 2025-08-19T10:47:18Z

Images are ready for the commit at dde9e83.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-527-gdde9e831bd.

codecov · 2025-08-19T10:51:29Z

Codecov Report

❌ Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.13%. Comparing base (df2a5d2) to head (dde9e83).
⚠️ Report is 27 commits behind head on master.

Files with missing lines	Patch %	Lines
sensor/common/networkflow/manager/manager_impl.go	75.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #16447      +/-   ##
==========================================
+ Coverage   49.07%   49.13%   +0.05%     
==========================================
  Files        2642     2641       -1     
  Lines      195773   195623     -150     
==========================================
+ Hits        96079    96115      +36     
+ Misses      92173    91968     -205     
- Partials     7521     7540      +19

Flag	Coverage Δ
go-unit-tests	`49.13% <90.56%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

rhacs-bot · 2025-08-20T13:19:04Z

/retest

lvalerom

Looks good!

Extract indicators into pkg

2e7b400

openshift-ci bot added the do-not-merge/work-in-progress label Aug 19, 2025

vikin91 mentioned this pull request Aug 19, 2025

ROX-30390: Leftovers from the prototype & code instrumentation #16238

Closed

9 tasks

github-actions bot added the area/sensor label Aug 19, 2025

vikin91 added 2 commits August 19, 2025 12:04

Add indicator pkg

d18a16b

Use the indicator pkg in manager

70282e8

vikin91 mentioned this pull request Aug 19, 2025

ROX-30390: Extract Update Computer #16452

Merged

9 tasks

Minor: Rephrase comments

dde9e83

vikin91 requested a review from lvalerom August 20, 2025 09:57

vikin91 marked this pull request as ready for review August 20, 2025 09:57

vikin91 requested a review from a team as a code owner August 20, 2025 09:57

openshift-ci bot removed the do-not-merge/work-in-progress label Aug 20, 2025

vikin91 added the ai-review label Aug 20, 2025

sourcery-ai bot reviewed Aug 20, 2025

View reviewed changes

vikin91 added the auto-retest PRs with this label will be automatically retested if prow checks fails label Aug 20, 2025

lvalerom approved these changes Aug 20, 2025

View reviewed changes

vikin91 merged commit 2827a49 into master Aug 21, 2025
103 checks passed

vikin91 deleted the piotr/ROX-30390-indicators branch August 21, 2025 07:47

This was referenced Aug 25, 2025

ROX-30390: Add TransitionBased update computer #16522

Merged

ROX-30390: Don't queue open enriched-entities forever #16532

Merged

This was referenced Sep 2, 2025

ROX-30390: Add indicator key functions #16621

Merged

ROX-30390: Refactor netFlowManager metrics #16624

Merged

vikin91 mentioned this pull request Sep 11, 2025

ROX-30390: Remove gauge metric for update types #16769

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROX-30390: Prefactor: Extract indicators into pkg#16447

ROX-30390: Prefactor: Extract indicators into pkg#16447
vikin91 merged 4 commits intomasterfrom
piotr/ROX-30390-indicators

vikin91 commented Aug 19, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Aug 19, 2025

Uh oh!

vikin91 commented Aug 19, 2025 •

edited

Loading

Uh oh!

red-hat-konflux bot commented Aug 19, 2025 •

edited

Loading

Uh oh!

rhacs-bot commented Aug 19, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 19, 2025 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

rhacs-bot commented Aug 20, 2025

Uh oh!

lvalerom left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vikin91 commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

openshift-ci bot commented Aug 19, 2025

Uh oh!

vikin91 commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

red-hat-konflux bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhacs-bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

rhacs-bot commented Aug 20, 2025

Uh oh!

lvalerom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vikin91 commented Aug 19, 2025 •

edited

Loading

vikin91 commented Aug 19, 2025 •

edited

Loading

red-hat-konflux bot commented Aug 19, 2025 •

edited

Loading

rhacs-bot commented Aug 19, 2025 •

edited

Loading

codecov bot commented Aug 19, 2025 •

edited

Loading