ROX-30390: Remove gauge metric for update types#16769
Merged
Conversation
Contributor
Author
|
This change is part of the following stack:
Change managed by git-spice. |
9 tasks
janisz
reviewed
Sep 11, 2025
janisz
approved these changes
Sep 11, 2025
Contributor
|
Images are ready for the commit at 858d48c. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16769 +/- ##
==========================================
- Coverage 48.81% 48.81% -0.01%
==========================================
Files 2681 2681
Lines 200391 200384 -7
==========================================
- Hits 97822 97811 -11
- Misses 94964 94968 +4
Partials 7605 7605
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
Base automatically changed from
piotr/ROX-30390-dont-queue-open-ee
to
master
September 11, 2025 13:18
It was difficult to capture the correct data for a gauge. The counter version of the same metric is still available.
8aed55f to
858d48c
Compare
Contributor
Author
|
/retest-required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was difficult to capture the correct data for a gauge, as it was required to use
Reset(). That made the metric values interrupted (for example: 60, nil, 70, nil, nil, 85). Recording it properly would require more changes and was not worth the effort.The counter version of the same metric is still available. The same result can be achieved using the counter version with
increase(the_counter_metric[30s])in Prometheus or Grafana.User-facing documentation
Testing and quality
Automated testing
How I validated my change
I haven't