Skip to content

ROX-31781: Fix PF6 styles for VM reporting#18888

Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31781-fix-vm-reporting
Feb 6, 2026
Merged

ROX-31781: Fix PF6 styles for VM reporting#18888
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31781-fix-vm-reporting

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 5, 2026

Description

Cleanup for VM reporting. As always, hide that whitespace.

Mostly removal of extraneous layout classes and <Card> wrappers.

One thing of note, is that utility classes for colors were split into separate icon and text variants, so report statuses have been updated accordingly.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

image image image image image image image image image

@dvail
Copy link
Contributor Author

dvail commented Feb 5, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail marked this pull request as ready for review February 5, 2026 21:35
@dvail dvail requested a review from a team as a code owner February 5, 2026 21:35
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (6543dee) to head (9d4d13d).
⚠️ Report is 3 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #18888      +/-   ##
=====================================================
- Coverage              49.44%   49.38%   -0.06%     
=====================================================
  Files                   2661     2659       -2     
  Lines                 200797   200734      -63     
=====================================================
- Hits                   99278    99127     -151     
- Misses                 94102    94165      +63     
- Partials                7417     7442      +25     
Flag Coverage Δ
go-unit-tests 49.38% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail merged commit be6e93a into dv/ROX-28622-pf-6 Feb 6, 2026
81 of 92 checks passed
@dvail dvail deleted the dv/ROX-31781-fix-vm-reporting branch February 6, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants