Skip to content

ROX-31784: Minor fixes for PF6 Risk page#18892

Merged
dvail merged 2 commits intodv/ROX-28622-pf-6from
dv/ROX-31784-fixes-for-pf6-risk
Feb 6, 2026
Merged

ROX-31784: Minor fixes for PF6 Risk page#18892
dvail merged 2 commits intodv/ROX-28622-pf-6from
dv/ROX-31784-fixes-for-pf6-risk

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 5, 2026

Description

Very minor cleanup from the recent partial migration of the Risk page.

The only functional change is the removal of the "count" header above the table.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

image image

@dvail
Copy link
Contributor Author

dvail commented Feb 5, 2026

@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail marked this pull request as ready for review February 5, 2026 22:08
@dvail dvail requested a review from a team as a code owner February 5, 2026 22:08
Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIg or small, clean them all.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (6543dee) to head (bd95d89).
⚠️ Report is 3 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #18892      +/-   ##
=====================================================
- Coverage              49.44%   49.38%   -0.06%     
=====================================================
  Files                   2661     2659       -2     
  Lines                 200797   200734      -63     
=====================================================
- Hits                   99278    99129     -149     
- Misses                 94102    94163      +61     
- Partials                7417     7442      +25     
Flag Coverage Δ
go-unit-tests 49.38% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from dv/ROX-31781-fix-vm-reporting to dv/ROX-28622-pf-6 February 6, 2026 13:31
@dvail dvail merged commit 661fb1f into dv/ROX-28622-pf-6 Feb 6, 2026
81 of 92 checks passed
@dvail dvail deleted the dv/ROX-31784-fixes-for-pf6-risk branch February 6, 2026 13:32
dvail added a commit that referenced this pull request Feb 6, 2026
dvail added a commit that referenced this pull request Feb 10, 2026
dvail added a commit that referenced this pull request Feb 11, 2026
dvail added a commit that referenced this pull request Feb 12, 2026
dvail added a commit that referenced this pull request Feb 13, 2026
dvail added a commit that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants