ROX-33388: Replace deprecated labelicon prop#19219
Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from Feb 27, 2026
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
fdb6501 to
61e8b26
Compare
61e8b26 to
564c868
Compare
pedrottimark
approved these changes
Feb 26, 2026
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
Ironically, one of our colleagues who contributes to integrations has expressed second thoughts about popup versus inline helper text.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #19219 +/- ##
====================================================
Coverage ? 49.51%
====================================================
Files ? 2666
Lines ? 201181
Branches ? 0
====================================================
Hits ? 99621
Misses ? 94121
Partials ? 7439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of the larger
tscfixes. ThelabelIconprop was replaced withlabelHelp, which should have been fixed by codemods but that does not appear to have been the case.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Visit the forms, verify the icon and popup function similarly to staging.
