ROX-33608: hook VM pipelines to V2 datastores#19553
Draft
dashrews78 wants to merge 1 commit intodashrews/virt-v2-ensure-33608from
Draft
ROX-33608: hook VM pipelines to V2 datastores#19553dashrews78 wants to merge 1 commit intodashrews/virt-v2-ensure-33608from
dashrews78 wants to merge 1 commit intodashrews/virt-v2-ensure-33608from
Conversation
Both the VM and scan-index pipelines now branch at runtime based on whether the v2 datastore Singleton is non-nil (feature flag VirtualMachinesEnhancedDataModel is ON). VM pipeline: Run dispatches to runV1/runV2 for upsert/delete; Reconcile dispatches to reconcileV1/reconcileV2. Scan-index pipeline: after enrichment, storeV1Scan (existing path) or storeV2Scan (EnsureVirtualMachineExists → ScanPartsFromV1Scan → UpsertScan). When the flag is OFF the Singleton returns nil and the v1 path is used unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at d29e74e. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dashrews/virt-v2-ensure-33608 #19553 +/- ##
=================================================================
+ Coverage 49.26% 49.30% +0.04%
=================================================================
Files 2729 2729
Lines 206035 206101 +66
=================================================================
+ Hits 101493 101618 +125
+ Misses 96996 96942 -54
+ Partials 7546 7541 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the VM and scan-index pipelines now branch at runtime based on
whether the v2 datastore Singleton is non-nil (feature flag
VirtualMachinesEnhancedDataModel is ON).
VM pipeline: Run dispatches to runV1/runV2 for upsert/delete;
Reconcile dispatches to reconcileV1/reconcileV2.
Scan-index pipeline: after enrichment, storeV1Scan (existing path) or
storeV2Scan (EnsureVirtualMachineExists → ScanPartsFromV1Scan →
UpsertScan).
When the flag is OFF the Singleton returns nil and the v1 path is used
unchanged.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!