Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
5 tasks
|
Tag for build #724352 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.70.x-542-g3fa2c167d8'🕹️ A |
3b92aac to
0dfa619
Compare
|
Images are ready for the commit at 3fa2c16. To use with deploy scripts, first |
048c22e to
6d122bb
Compare
theencee
approved these changes
Jun 16, 2022
6d122bb to
25526b3
Compare
25526b3 to
deee13b
Compare
rukletsov
approved these changes
Jun 30, 2022
deee13b to
3fa2c16
Compare
Contributor
Author
|
/retest-required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first PR in a series of PRs regarding removing the composite key from the groups datastore, allowing users to specify different roles for the same group properties.
For full context and overview, you can navigate across the PRs within this series via the generated comment.
This will add the field
idto theGroupPropertiesproto.The reason why the ID field was added to the GroupProperties message was due to the fact that the API itself requires the
GroupPropertiesas input forGetGroup / RemoveGroupendpoints.I'm open for other suggestions, i.e. refactoring the API completely, but I do not see a way of doing this without proper announcement beforehand, thus delaying the fix for this.
Checklist
If any of these don't apply, please comment below.
Testing Performed