ROX-11070: Remove unused de-serialization of groups#2160
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
This was referenced Jun 22, 2022
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Tag for build #730622 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.70.x-567-gedce58979b'🕹️ A |
e4f75d9 to
f642da0
Compare
a7d5504 to
41418b2
Compare
rukletsov
approved these changes
Jun 30, 2022
f642da0 to
6d061fe
Compare
41418b2 to
99e2a16
Compare
6d061fe to
c5828e5
Compare
99e2a16 to
287b25e
Compare
287b25e to
edce589
Compare
Contributor
Author
|
/retest |
|
Images are ready for the commit at edce589. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up from removing the composite key of the groups data store. Previously, groups where uniquely identified and stored in a key-value store by their properties. For this, the serialization package serialized and de-serialized the properties into a key.
This PR will remove the de-serialization part. The serialization part is still used within the group service for differentiating between different groups, using the properties and role name of the group as key in a map to make this more efficient.