Conversation
This was referenced Jul 4, 2022
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Tag for build #730864 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.70.x-571-g2c7d8d8164'🕹️ A |
rukletsov
reviewed
Jul 4, 2022
666fb17 to
7db4450
Compare
ab96951 to
7840840
Compare
rukletsov
approved these changes
Jul 4, 2022
| s.ErrorIs(err, errox.AlreadyExists) | ||
|
|
||
| // 3. Updating the initially existing group to make it a default group should fail. | ||
| // Fetch the group by its properties. |
Member
There was a problem hiding this comment.
That's an interesting styling approach : ).
Contributor
Author
There was a problem hiding this comment.
Learnt it from the best 😜
14e3956 to
2c7d8d8
Compare
|
Images are ready for the commit at 2c7d8d8. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up from the discussion here.
The issue is that, with the changes of introducing a unique identifier not based on a composite key of a group's properties, we potentially allow clients to create an arbitrary amount of default groups.
Previously, this was not possible due to the
authProviderID's value being used as a key to store the group, uniquely identifying it, creating a 1:1 mapping between default group and auth provider.This complicates things for the UI, as we would either change the current flow within the UI and allow multiple "default roles" to be assigned, as well as posing a challenge to distinguish between the different default groups.
Since this is not at all intended, we should restrict the datastore and only allow a single default group (with no key / value field set) per auth provider ID. This way, we achieve the same behavior related to default groups as
beforehand and do not add increased complexity to the front end.
Testing Performed