Skip to content

ROX-12975: Use new Scanner API for Node scanning#3940

Closed
vikin91 wants to merge 5 commits intopr/add-nodeComponents-to-Nodefrom
pr/central-handle-extended-node
Closed

ROX-12975: Use new Scanner API for Node scanning#3940
vikin91 wants to merge 5 commits intopr/add-nodeComponents-to-Nodefrom
pr/central-handle-extended-node

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Nov 29, 2022

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vikin91 vikin91 changed the title Use new Scanner API for Node scanning ROX-12975: Use new Scanner API for Node scanning Nov 29, 2022
@vikin91 vikin91 force-pushed the pr/add-nodeComponents-to-Node branch from 8533c80 to 8a3fe78 Compare November 30, 2022 08:07
@vikin91 vikin91 force-pushed the pr/central-handle-extended-node branch from 91d7a3f to d1723e9 Compare November 30, 2022 08:13
@vikin91 vikin91 force-pushed the pr/add-nodeComponents-to-Node branch 2 times, most recently from a354d5f to 28d3f61 Compare December 1, 2022 15:58
@vikin91 vikin91 force-pushed the pr/add-nodeComponents-to-Node branch 3 times, most recently from d8f2ea4 to 6bf493c Compare January 4, 2023 09:11
@vikin91 vikin91 force-pushed the pr/central-handle-extended-node branch from d1723e9 to 0f6cefa Compare January 4, 2023 13:14
@ghost
Copy link

ghost commented Jan 4, 2023

Images are ready for the commit at 931b180.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.x-381-g931b180343.

@vikin91 vikin91 force-pushed the pr/add-nodeComponents-to-Node branch from 6bf493c to c94f16d Compare January 6, 2023 10:46
@vikin91 vikin91 force-pushed the pr/central-handle-extended-node branch from 0f6cefa to c89fa99 Compare January 6, 2023 10:47
@vikin91 vikin91 force-pushed the pr/add-nodeComponents-to-Node branch from 615abd4 to 1398927 Compare January 11, 2023 17:12
@vikin91 vikin91 force-pushed the pr/central-handle-extended-node branch from bb6bc8e to 931b180 Compare January 11, 2023 17:28
@vikin91
Copy link
Contributor Author

vikin91 commented Jan 20, 2023

Closing in favor of #4492

@vikin91 vikin91 closed this Jan 20, 2023
@vikin91 vikin91 deleted the pr/central-handle-extended-node branch January 20, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant