ROX-12943: Sensor maps the NodeInventory to Node#3892
Closed
vikin91 wants to merge 4 commits intopr/add-nodeComponents-to-Nodefrom
Closed
ROX-12943: Sensor maps the NodeInventory to Node#3892vikin91 wants to merge 4 commits intopr/add-nodeComponents-to-Nodefrom
vikin91 wants to merge 4 commits intopr/add-nodeComponents-to-Nodefrom
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
This was referenced Nov 23, 2022
vikin91
commented
Nov 23, 2022
|
|
||
| func (c *nodeScanHandlerImpl) fakeAndSendToCentral(toC chan *central.MsgFromSensor, scan *storage.NodeInventory) { | ||
| if scan == nil { | ||
| func (c *nodeScanHandlerImpl) attachToNodeEndToCentral(toC chan<- *central.MsgFromSensor, inventory *storage.NodeInventory) { |
Contributor
Author
There was a problem hiding this comment.
Make sure to add here rich and reasonable log output here.
ca013ad to
c3df70d
Compare
931e02c to
b2765a0
Compare
f6906a5 to
8533c80
Compare
d03dbff to
ae9aacb
Compare
This was referenced Nov 29, 2022
8533c80 to
8a3fe78
Compare
ae9aacb to
77e2995
Compare
a354d5f to
28d3f61
Compare
d8f2ea4 to
6bf493c
Compare
|
Images are ready for the commit at 01dbe39. To use with deploy scripts, first |
6bf493c to
c94f16d
Compare
b9d4ced to
762dc0d
Compare
615abd4 to
1398927
Compare
762dc0d to
01b47d6
Compare
01b47d6 to
01dbe39
Compare
d7da815 to
96bb013
Compare
This was referenced Jan 17, 2023
Closed
Contributor
Author
|
Closing in favor of #4484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.