Skip to content

ROX-14973: Use batch/v1 in 3.72 for compatibility with OCP 4.12#4790

Closed
JoukoVirtanen wants to merge 3 commits intorelease-3.72from
jv-fix-for-k8s-v1.25
Closed

ROX-14973: Use batch/v1 in 3.72 for compatibility with OCP 4.12#4790
JoukoVirtanen wants to merge 3 commits intorelease-3.72from
jv-fix-for-k8s-v1.25

Conversation

@JoukoVirtanen
Copy link
Contributor

@JoukoVirtanen JoukoVirtanen commented Feb 8, 2023

Description

Brings in the changes from here #3854 to 3.72 to fix https://issues.redhat.com/browse/ROX-14973

Checklist

  • Investigated and inspected CI test results
  • Confirmed that the issue was fixed

Testing Performed

Planned testing

infractl create openshift-4 jouko-0208-ocp-4-12-1 --description "Testing bug with k8s 1.25" --arg openshift-version=ocp/4.12.1

export CENTRAL_IMAGE_REGISTRY=quay.io/stackrox-io
export CENTRAL_IMAGE_NAME=main
export CENTRAL_IMAGE_TAG=3.72.3

export SCANNER_DBIMAGE_REGISTRY=quay.io/stackrox-io
export SCANNER_DBIMAGE_NAME=scanner-db
export SCANNER_DBIMAGE_TAG=2.26.2

export IMAGE_MAIN_REGISTRY=quay.io/stackrox-io
export IMAGE_MAIN_NAME=main
export IMAGE_MAIN_TAG=3.72.3

collector_image_tag=3.11.2

Deploy using helm. Confirm that the NetworkGraph is not correct. Switch to patch version and confirm that it working correctly.

@msugakov msugakov changed the title Jv fix for k8s v1.25 ROX-14973: Use CronJob v1 in 3.72 for compatibility with OCP 4.12 Feb 9, 2023
@msugakov msugakov changed the title ROX-14973: Use CronJob v1 in 3.72 for compatibility with OCP 4.12 ROX-14973: Use batch/v1 in 3.72 for compatibility with OCP 4.12 Feb 9, 2023
@Molter73
Copy link
Contributor

Molter73 commented Feb 9, 2023

/test all

@Molter73
Copy link
Contributor

Molter73 commented Feb 9, 2023

I don't fully understand why there are no tests being triggered in this PR

@msugakov
Copy link
Contributor

msugakov commented Feb 9, 2023

@Molter73 See here https://srox.slack.com/archives/C03D78P4RFF/p1675935807775399

@robbycochran robbycochran added this to the 3.72.4-rc.1 milestone Feb 10, 2023
@robbycochran robbycochran removed this from the 3.72.4-rc.1 milestone Feb 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2023

@JoukoVirtanen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/go-unit-tests d32b43d link true /test go-unit-tests
ci/prow/go-unit-tests-release d32b43d link true /test go-unit-tests-release

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ghost
Copy link

ghost commented Feb 11, 2023

Images are ready for the commit at d32b43d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.3-3-gd32b43dead.

@msugakov
Copy link
Contributor

Will be replaced by #4830
Closing for now to avoid getting confused.

@msugakov msugakov closed this Feb 13, 2023
@JoukoVirtanen JoukoVirtanen deleted the jv-fix-for-k8s-v1.25 branch September 16, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants