Start using the batch/v1 api for CronJobs#3854
Merged
Conversation
|
Images are ready for the commit at 9963217. To use with deploy scripts, first |
fredrb
reviewed
Nov 21, 2022
Contributor
We don't have any CronJob resources in the replay tests nor specific tests in the integration tests, so no. |
md2119
approved these changes
Nov 21, 2022
Contributor
Author
Contributor
3d93bd2 to
ee5358f
Compare
9031c5b to
9963217
Compare
JoukoVirtanen
pushed a commit
that referenced
this pull request
Feb 8, 2023
2 tasks
JoukoVirtanen
pushed a commit
that referenced
this pull request
Feb 8, 2023
2 tasks
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 10, 2023
1 task
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 11, 2023
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 11, 2023
1 task
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 14, 2023
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes stackrox/collector#907
The
v1beta1.CronJobapi is unavailable in k8s v1.25 and it causes sensor to not be able to synchronize k8s resources, which in turn causes all information gathered by collector to be discarded (since sensor is not able to link container IDs to k8s resources).The
v1.CronJobAPI has been available since k8s v1.21 (which is already EOL). Older versions are no longer supported by k8s or openshift, so we should be safe to make this change.Checklist
If any of these don't apply, please comment below.
Testing Performed