Skip to content

ROX-14973: Use batch/v1 in 3.73 for compatibility with OCP 4.12#4791

Closed
JoukoVirtanen wants to merge 2 commits intorelease-3.73from
use-v1-cronjobs-for-deployments-3.73
Closed

ROX-14973: Use batch/v1 in 3.73 for compatibility with OCP 4.12#4791
JoukoVirtanen wants to merge 2 commits intorelease-3.73from
use-v1-cronjobs-for-deployments-3.73

Conversation

@JoukoVirtanen
Copy link
Contributor

@JoukoVirtanen JoukoVirtanen commented Feb 8, 2023 •
edited
Loading

Description

Brings in the changes from here #3854 to 3.73 to fix https://issues.redhat.com/browse/ROX-14973

Checklist

  • Investigated and inspected CI test results
  • Confirmed that the issue was fixed

Testing Performed

Planned testing

infractl create openshift-4 jouko-0208-ocp-4-12-1 --description "Testing bug with k8s 1.25" --arg openshift-version=ocp/4.12.1

export CENTRAL_IMAGE_REGISTRY=quay.io/stackrox-io
export CENTRAL_IMAGE_NAME=main
export CENTRAL_IMAGE_TAG=3.73.2

export SCANNER_DBIMAGE_REGISTRY=quay.io/stackrox-io
export SCANNER_DBIMAGE_NAME=scanner-db
export SCANNER_DBIMAGE_TAG=2.27.5

export IMAGE_MAIN_REGISTRY=quay.io/stackrox-io
export IMAGE_MAIN_NAME=main
export IMAGE_MAIN_TAG=3.73.2

collector_image_tag=3.12.1

Deploy using helm. Confirm that the NetworkGraph is not correct. Switch to patch version and confirm that it working correctly.

@JoukoVirtanen JoukoVirtanen changed the base branch from release-3.73 to master February 9, 2023 04:59
@JoukoVirtanen JoukoVirtanen requested a review from a team February 9, 2023 04:59
@JoukoVirtanen JoukoVirtanen requested review from a team as code owners February 9, 2023 04:59
@gitguardian
Copy link

gitguardian bot commented Feb 9, 2023 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@JoukoVirtanen JoukoVirtanen changed the base branch from master to release-3.73 February 9, 2023 05:00
porridge
porridge approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the oldest OpenShift we need to support is 4.8, based on k8s 1.21, which mentions:

  • Promote CronJobs to batch/v1 [...]

@Molter73
Copy link
Contributor

Molter73 commented Feb 9, 2023

/retest

@msugakov msugakov changed the title Use v1 cronjobs for deployments 3.73 ROX-14973: Use batch/v1 in 3.73 for compatibility with OCP 4.12 Feb 9, 2023
@msugakov
Copy link
Contributor

msugakov commented Feb 9, 2023

I think this change needs a CHANGELOG.md record.
Let me try do some testing on OCP 4.7 (k8s 1.20) and 4.8 (k8s 1.21).

@msugakov
Copy link
Contributor

msugakov commented Feb 9, 2023

I understand that E2E tests fail apart here (e.g. this job) because OSCI tries to merge the code with master branch and runs into conflicts on CHANGELOG.md.

@robbycochran robbycochran added this to the 3.73.3-rc.1 milestone Feb 10, 2023
@ghost
Copy link

ghost commented Feb 10, 2023

Images are ready for the commit at 024ecc9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.2-2-g024ecc9f00.

@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2023 •
edited
Loading

@JoukoVirtanen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-postgres-ui-e2e-tests 024ecc9 link false /test gke-postgres-ui-e2e-tests
ci/prow/gke-postgres-upgrade-tests 024ecc9 link false /test gke-postgres-upgrade-tests
ci/prow/gke-postgres-nongroovy-e2e-tests 024ecc9 link false /test gke-postgres-nongroovy-e2e-tests
ci/prow/openshift-oldest-qa-e2e-tests 024ecc9 link false /test openshift-oldest-qa-e2e-tests
ci/prow/openshift-newest-qa-e2e-tests 024ecc9 link false /test openshift-newest-qa-e2e-tests
ci/prow/openshift-oldest-operator-e2e-tests 024ecc9 link false /test openshift-oldest-operator-e2e-tests
ci/prow/openshift-penultimate-qa-e2e-tests 024ecc9 link false /test openshift-penultimate-qa-e2e-tests
ci/prow/openshift-newest-operator-e2e-tests 024ecc9 link false /test openshift-newest-operator-e2e-tests
ci/prow/grouped-static-checks 024ecc9 link true /test grouped-static-checks
ci/prow/gke-ui-e2e-tests 024ecc9 link true /test gke-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msugakov
Copy link
Contributor

msugakov commented Feb 13, 2023

Will be replaced by #4829
Closing for now to avoid confusion.

@msugakov msugakov closed this Feb 13, 2023
@JoukoVirtanen JoukoVirtanen deleted the use-v1-cronjobs-for-deployments-3.73 branch September 16, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porridge porridge porridge approved these changes

Assignees

No one assigned

Labels

area/sensor

Projects

None yet

Milestone

3.73.3-rc.1

Development

Successfully merging this pull request may close these issues.

5 participants

@JoukoVirtanen @Molter73 @msugakov @porridge @robbycochran