Skip to content

ROX-27490: Generate failed cluster report#15212

Merged
lvalerom merged 5 commits intomasterfrom
lvm/rox-27490-generate-failed-cluster-report
May 19, 2025
Merged

ROX-27490: Generate failed cluster report#15212
lvalerom merged 5 commits intomasterfrom
lvm/rox-27490-generate-failed-cluster-report

Conversation

@lvalerom
Copy link
Contributor

@lvalerom lvalerom commented May 7, 2025 •
edited
Loading

Description

Given a map of failed clusters. The CSV formatter will generate a file per failed cluster with the reason for the failure.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

@openshift-ci
Copy link

openshift-ci bot commented May 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lvalerom lvalerom changed the base branch from master to lvm/rox-27490-add-failed-clusters-to-storage-protos May 7, 2025 11:10
@lvalerom lvalerom mentioned this pull request May 7, 2025
Closed
9 tasks
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 7, 2025 •
edited
Loading

Images are ready for the commit at 11950dd.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-734-g11950ddb05.

@codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.13%. Comparing base (4f402ec) to head (55b99fe).

Additional details and impacted files 
@@                                 Coverage Diff                                  @@
##           lvm/rox-27490-add-failed-clusters-to-storage-protos   #15212   +/-   ##
====================================================================================
  Coverage                                                49.12%   49.13%           
====================================================================================
  Files                                                     2558     2558           
  Lines                                                   187891   187916   +25     
====================================================================================
+ Hits                                                     92300    92329   +29     
+ Misses                                                   88311    88308    -3     
+ Partials                                                  7280     7279    -1
Flag Coverage Δ
go-unit-tests 49.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lvalerom lvalerom mentioned this pull request May 8, 2025
Merged
11 tasks
@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-to-storage-protos branch from 13bef89 to d4d7962 Compare May 8, 2025 10:56
@lvalerom lvalerom force-pushed the lvm/rox-27490-generate-failed-cluster-report branch from 095f10a to 6dae686 Compare May 8, 2025 10:57
@lvalerom lvalerom marked this pull request as ready for review May 9, 2025 10:27
@lvalerom lvalerom requested review from dashrews78, mtodor and vikin91 May 9, 2025 10:37
@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-to-storage-protos branch from d4d7962 to 4f402ec Compare May 9, 2025 10:47
@lvalerom lvalerom requested a review from a team as a code owner May 9, 2025 10:47
@lvalerom lvalerom force-pushed the lvm/rox-27490-generate-failed-cluster-report branch from 6dae686 to cd85a53 Compare May 9, 2025 10:48
mtodor
mtodor reviewed May 12, 2025
View reviewed changes
vikin91
vikin91 approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. We can fix the missing bits (if any) in the other PR when this all is populated and can be tested on a cluster.

mtodor
mtodor approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@mtodor mtodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

I have added a few nitpicks and considerations, but I would not postpone the PR merge because of them. If you are going to address other review comments, then you can consider addressing nitpicks.

@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-to-storage-protos branch 2 times, most recently from e9a3923 to 9d8eb96 Compare May 16, 2025 11:10
Base automatically changed from lvm/rox-27490-add-failed-clusters-to-storage-protos to master May 16, 2025 16:19
@lvalerom lvalerom force-pushed the lvm/rox-27490-generate-failed-cluster-report branch from 55b99fe to 11950dd Compare May 16, 2025 16:55
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2025 •
edited
Loading

@lvalerom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-scanner-v4-install-tests 55b99fe link false /test ocp-4-12-scanner-v4-install-tests
ci/prow/ocp-4-12-operator-e2e-tests 55b99fe link false /test ocp-4-12-operator-e2e-tests
ci/prow/gke-operator-e2e-tests 55b99fe link false /test gke-operator-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests 55b99fe link false /test ocp-4-12-qa-e2e-tests
ci/prow/gke-scanner-v4-install-tests 55b99fe link false /test gke-scanner-v4-install-tests
ci/prow/gke-ui-e2e-tests 55b99fe link false /test gke-ui-e2e-tests
ci/prow/ocp-4-12-ui-e2e-tests 55b99fe link false /test ocp-4-12-ui-e2e-tests
ci/prow/ocp-4-18-ui-e2e-tests 55b99fe link false /test ocp-4-18-ui-e2e-tests
ci/prow/ocp-4-18-operator-e2e-tests 55b99fe link false /test ocp-4-18-operator-e2e-tests
ci/prow/ocp-4-18-scanner-v4-install-tests 55b99fe link false /test ocp-4-18-scanner-v4-install-tests
ci/prow/ocp-4-18-qa-e2e-tests 55b99fe link false /test ocp-4-18-qa-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests 11950dd link false /test ocp-4-12-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lvalerom lvalerom merged commit ad1344e into master May 19, 2025
86 of 87 checks passed
@lvalerom lvalerom deleted the lvm/rox-27490-generate-failed-cluster-report branch May 19, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikin91 vikin91 vikin91 approved these changes

@mtodor mtodor mtodor approved these changes

@dashrews78 dashrews78 Awaiting requested review from dashrews78

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lvalerom @rhacs-bot @vikin91 @mtodor