Skip to content

DO-NOT-MERGE: add failed clusters information#13760

Closed
lvalerom wants to merge 1 commit intomasterfrom
lvm/rox-27490-add-failed-clusters-information
Closed

DO-NOT-MERGE: add failed clusters information#13760
lvalerom wants to merge 1 commit intomasterfrom
lvm/rox-27490-add-failed-clusters-information

Conversation

@lvalerom
Copy link
Contributor

@lvalerom lvalerom commented Jan 9, 2025 •
edited
Loading

Description

This is going to be divided in:

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-information branch from 0d2788f to 8711b62 Compare January 9, 2025 13:22
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 9, 2025 •
edited
Loading

Images are ready for the commit at c4f2d62.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-614-gc4f2d6282f.

@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-information branch from 8711b62 to 416f231 Compare January 9, 2025 15:25
@lvalerom lvalerom force-pushed the lvm/rox-26738-refactor-send-function branch from bd7fa23 to 9e23153 Compare January 14, 2025 14:45
Base automatically changed from lvm/rox-26738-refactor-send-function to master January 14, 2025 20:30
@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-information branch from 3de8ce9 to b795ba3 Compare January 15, 2025 07:16
@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-information branch from b795ba3 to 66514bb Compare April 8, 2025 15:42
@codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.52941% with 36 lines in your changes missing coverage. Please review.

Project coverage is 49.10%. Comparing base (0219866) to head (c4f2d62).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...mplianceoperator/v2/report/manager/manager_impl.go 63.63% 25 Missing and 7 partials ⚠️
...or/v2/report/manager/results/results_aggregator.go 62.50% 2 Missing and 1 partial ⚠️
...eoperator/v2/report/manager/watcher/scanwatcher.go 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #13760      +/-   ##
==========================================
- Coverage   49.11%   49.10%   -0.01%     
==========================================
  Files        2557     2557              
  Lines      187876   187915      +39     
==========================================
+ Hits        92269    92272       +3     
- Misses      88336    88370      +34     
- Partials     7271     7273       +2
Flag Coverage Δ
go-unit-tests 49.10% <73.52%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-information branch 2 times, most recently from 40e20d9 to e4c7dd3 Compare April 30, 2025 20:13
@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-information branch 3 times, most recently from 6e9d115 to 02bf30f Compare May 5, 2025 14:12
@lvalerom lvalerom force-pushed the lvm/rox-27490-add-failed-clusters-information branch from 02bf30f to c4f2d62 Compare May 5, 2025 19:45
@lvalerom lvalerom changed the title ROX-27490: add failed clusters information DO-NOT-MERGE: add failed clusters information May 9, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2025

@lvalerom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-ui-e2e-tests c4f2d62 link true /test gke-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lvalerom lvalerom closed this May 30, 2025
@lvalerom lvalerom deleted the lvm/rox-27490-add-failed-clusters-information branch September 17, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/central do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lvalerom @rhacs-bot