Merged
Conversation
|
Skipping CI for Draft Pull Request. |
9 tasks
Contributor
|
Images are ready for the commit at 002dd10. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15218 +/- ##
==========================================
+ Coverage 49.13% 49.25% +0.12%
==========================================
Files 2570 2574 +4
Lines 188682 188908 +226
==========================================
+ Hits 92701 93049 +348
+ Misses 88668 88540 -128
- Partials 7313 7319 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
11 tasks
13bef89 to
d4d7962
Compare
5e2be20 to
92c0ad5
Compare
d4d7962 to
4f402ec
Compare
92c0ad5 to
f491ed5
Compare
mtodor
reviewed
May 14, 2025
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
central/complianceoperator/v2/report/manager/watcher/validator_test.go
Outdated
Show resolved
Hide resolved
e9a3923 to
9d8eb96
Compare
Base automatically changed from
lvm/rox-27490-add-failed-clusters-to-storage-protos
to
master
May 16, 2025 16:19
f491ed5 to
13315f8
Compare
3a42aaa to
37069e5
Compare
mtodor
reviewed
May 21, 2025
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
central/complianceoperator/v2/report/manager/watcher/validator.go
Outdated
Show resolved
Hide resolved
|
@lvalerom: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
mtodor
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate the
ScanResultsand generate thefailedClustersmap.User-facing documentation
Testing and quality
Automated testing
How I validated my change