Skip to content

ROX-31779: [part 1] Fix layout for VM Workload CVEs results#18808

Merged
dvail merged 4 commits intodv/ROX-28622-pf-6from
dv/ROX-31779-fix-vm-results
Feb 4, 2026
Merged

ROX-31779: [part 1] Fix layout for VM Workload CVEs results#18808
dvail merged 4 commits intodv/ROX-28622-pf-6from
dv/ROX-31779-fix-vm-results

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 3, 2026 •
edited
Loading

Description

Best reviewed with Hide whitespace on - most changes are indentation

Fixes visual layout issues in VM->Workload CVE sections. The primary changes are:

  1. Delete as many className props and wrapper divs as possible
  2. Use appropriate <PageSection> props (e.g. type="tabs")
  3. Fix table row borders, custom style still :(

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Fixed Cypress tests under vulnerabilities/workloadCves:

image image

Overview:
image
image
image
image

image image image

CVE page:
image
image
image

Image page:
image

image image

Deployment page:
image
image
image

@dvail
Copy link
Contributor Author

dvail commented Feb 3, 2026 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@dvail dvail mentioned this pull request Feb 3, 2026
Draft
9 tasks
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail force-pushed the dv/ROX-31779-fix-vm-results branch 4 times, most recently from 8ae51d4 to 27c5c3f Compare February 3, 2026 14:47
@dvail dvail marked this pull request as ready for review February 3, 2026 15:07
@dvail dvail requested a review from a team as a code owner February 3, 2026 15:07
@dvail dvail mentioned this pull request Feb 3, 2026
Merged
9 tasks
@codecov
Copy link

codecov bot commented Feb 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (731e227) to head (971c497).
⚠️ Report is 1 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #18808      +/-   ##
=====================================================
- Coverage              49.38%   49.38%   -0.01%     
=====================================================
  Files                   2659     2659              
  Lines                 200734   200734              
=====================================================
- Hits                   99141    99132       -9     
- Misses                 94154    94161       +7     
- Partials                7439     7441       +2
Flag Coverage Δ
go-unit-tests 49.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail mentioned this pull request Feb 3, 2026
Merged
9 tasks
pedrottimark
pedrottimark reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PatternFly has layout, so className, className, go.
Here a prop, there a prop, everywhere a prop, prop!

@dvail dvail merged commit 0f2cec7 into dv/ROX-28622-pf-6 Feb 4, 2026
126 of 169 checks passed
@dvail dvail deleted the dv/ROX-31779-fix-vm-results branch February 4, 2026 13:51
dvail added a commit that referenced this pull request Feb 6, 2026
@dvail
ROX-31779: [part 1] Fix layout for VM Workload CVEs results (#18808)
02ddd21
dvail added a commit that referenced this pull request Feb 10, 2026
@dvail
ROX-31779: [part 1] Fix layout for VM Workload CVEs results (#18808)
2ec3192
dvail added a commit that referenced this pull request Feb 11, 2026
@dvail
ROX-31779: [part 1] Fix layout for VM Workload CVEs results (#18808)
17636be
dvail added a commit that referenced this pull request Feb 12, 2026
@dvail
ROX-31779: [part 1] Fix layout for VM Workload CVEs results (#18808)
4325abd
dvail added a commit that referenced this pull request Feb 13, 2026
@dvail
ROX-31779: [part 1] Fix layout for VM Workload CVEs results (#18808)
01d3632
dvail added a commit that referenced this pull request Feb 27, 2026
@dvail
ROX-31779: [part 1] Fix layout for VM Workload CVEs results (#18808)
8dd7924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrottimark pedrottimark pedrottimark approved these changes

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvail @pedrottimark