ROX-31779: [part 3] Fix layout on VM->K8s components pages#18820
ROX-31779: [part 3] Fix layout on VM->K8s components pages#18820dvail merged 1 commit intodv/ROX-28622-pf-6from
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
d50d938 to
9f4d362
Compare
88e2ec3 to
9af12da
Compare
ui/apps/platform/src/Containers/Vulnerabilities/PlatformCves/Cluster/ClusterPage.tsx
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #18820 +/- ##
=====================================================
- Coverage 49.39% 49.38% -0.02%
=====================================================
Files 2659 2659
Lines 200615 200734 +119
=====================================================
+ Hits 99097 99133 +36
- Misses 94100 94160 +60
- Partials 7418 7441 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9af12da to
cf2c313
Compare
ui/apps/platform/src/Containers/Vulnerabilities/PlatformCves/Cluster/ClusterPage.tsx
Show resolved
Hide resolved
ui/apps/platform/src/Containers/Vulnerabilities/PlatformCves/Cluster/ClusterPage.tsx
Show resolved
Hide resolved
| )} | ||
| </CardBody> | ||
| </Card> | ||
| <Divider component="div" /> |
There was a problem hiding this comment.
After so many deletions of Divider elements, this caught my eye.
What is pro and con to omit between test and description list, especially if text blurb (that states the obvious) under tabs is not a pattern in OpenShift Console pages.
There was a problem hiding this comment.
text blurb under tabs is not a pattern in OpenShift Console pages
This is the part that made me keep the dividers here. There isn't a good example from the console that shows the same, and my subjective opinion was that the divider between text and rest of content looked good (or at least the inverse looked out of place). Not sure if this is just familiarity with these pages or not, but I'm open to getting rid of this in a second round of follow ups. Right now, I was leaning towards less changes instead of more, unless there was a clear precedent in the console to follow.
Description
Part 3 - layout fix for k8s components using the same strategy in parts 1 and 2. As always, hide whitespace.
User-facing documentation
Testing and quality
Automated testing
How I validated my change