ROX-31779: [part 2] Fix layout on VM->Nodes pages#18812
Merged
dvail merged 5 commits intodv/ROX-28622-pf-6from Feb 4, 2026
Merged
ROX-31779: [part 2] Fix layout on VM->Nodes pages#18812dvail merged 5 commits intodv/ROX-28622-pf-6from
dvail merged 5 commits intodv/ROX-28622-pf-6from
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
dvail
commented
Feb 3, 2026
dvail
commented
Feb 3, 2026
ui/apps/platform/src/Containers/Vulnerabilities/NodeCves/Node/NodePage.tsx
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #18812 +/- ##
==================================================
Coverage 49.38% 49.38%
==================================================
Files 2659 2659
Lines 200734 200734
==================================================
+ Hits 99141 99142 +1
+ Misses 94154 94153 -1
Partials 7439 7439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 3, 2026
d50d938 to
9f4d362
Compare
pedrottimark
reviewed
Feb 3, 2026
ui/apps/platform/src/Containers/Vulnerabilities/NodeCves/Node/NodePageVulnerabilities.tsx
Show resolved
Hide resolved
pedrottimark
reviewed
Feb 3, 2026
ui/apps/platform/src/Containers/Vulnerabilities/NodeCves/Overview/NodeCvesOverviewPage.tsx
Show resolved
Hide resolved
pedrottimark
approved these changes
Feb 3, 2026
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
Especially thankful to see card and divider in the deleted column.
Base automatically changed from
dv/ROX-31779-fix-vm-results
to
dv/ROX-28622-pf-6
February 4, 2026 13:51
dvail
added a commit
that referenced
this pull request
Feb 6, 2026
dvail
added a commit
that referenced
this pull request
Feb 10, 2026
dvail
added a commit
that referenced
this pull request
Feb 11, 2026
dvail
added a commit
that referenced
this pull request
Feb 12, 2026
dvail
added a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 2 for VM migration - Nodes pages. (See #18808 for part one).
Hide whitespace is highly recommended
Again, the fixes here are primarily handled by removing all extraneous classname props and wrapper components.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Updated Cypress tests:
Overview:
CVE Page:
Node Page:
