Draft
Conversation
Add search/sql tags to VirtualMachineScanV2.scan_time so it becomes a queryable database column (previously only in serialized blob). Add uint64 hash fields to both VirtualMachineV2 and VirtualMachineScanV2 for change detection in the upcoming custom store implementation. These are prerequisites for the custom VM v2 store that will use hash-based comparison to avoid unnecessary writes and support timestamp-only updates when data has not changed. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Feb 27, 2026
Contributor
|
Images are ready for the commit at 49e3b83. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19237 +/- ##
==========================================
- Coverage 49.56% 49.55% -0.01%
==========================================
Files 2675 2675
Lines 201838 201838
==========================================
- Hits 100032 100027 -5
- Misses 94348 94351 +3
- Partials 7458 7460 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first draft
ran the generators
Add scan_time DB column tags and hash fields to VM v2 protos
Add search/sql tags to VirtualMachineScanV2.scan_time so it becomes a
queryable database column (previously only in serialized blob). Add
uint64 hash fields to both VirtualMachineV2 and VirtualMachineScanV2
for change detection in the upcoming custom store implementation.
These are prerequisites for the custom VM v2 store that will use
hash-based comparison to avoid unnecessary writes and support
timestamp-only updates when data has not changed.
Partially generated by AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!