Skip to content

ROX-32747: generate stores#19239

Draft
dashrews78 wants to merge 3 commits intodashrews/vm-v2-schema-33338from
dashrews/vm-v2-generic-stores
Draft

ROX-32747: generate stores#19239
dashrews78 wants to merge 3 commits intodashrews/vm-v2-schema-33338from
dashrews/vm-v2-generic-stores

Conversation

@dashrews78
Copy link
Contributor

Remove --schema-only from VM v2 gen.go files to generate full stores

Removes --schema-only from the scan, component, and CVE v2 gen.go files
so the code generator produces store.go and store_test.go with full CRUD
operations. Adds --no-copy-from to the scan store since it is referenced
by other tables via foreign keys.

Partially generated by AI

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Generate full VM v2 postgres store with --no-copy-from flag

Remove --schema-only from gen.go and add --no-copy-from to generate
the complete store implementation for VirtualMachineV2.

Partially generated by AI.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

regen

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

dashrews78 and others added 3 commits February 27, 2026 14:40
Removes --schema-only from the scan, component, and CVE v2 gen.go files
so the code generator produces store.go and store_test.go with full CRUD
operations. Adds --no-copy-from to the scan store since it is referenced
by other tables via foreign keys.

Partially generated by AI

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove --schema-only from gen.go and add --no-copy-from to generate
the complete store implementation for VirtualMachineV2.

Partially generated by AI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dashrews78
Copy link
Contributor Author

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 3bb7454.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-208-g3bb745427f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants