ROX-33338: VM v2 generate schemas#19238
Draft
dashrews78 wants to merge 3 commits intodashrews/vm-v2-proto-32746from
Draft
ROX-33338: VM v2 generate schemas#19238dashrews78 wants to merge 3 commits intodashrews/vm-v2-proto-32746from
dashrews78 wants to merge 3 commits intodashrews/vm-v2-proto-32746from
Conversation
Add four new search categories (VIRTUAL_MACHINES_V2, VIRTUAL_MACHINE_SCANS_V2, VIRTUAL_MACHINE_COMPONENTS_V2, VIRTUAL_MACHINE_VULNERABILITIES_V2) to search_service.proto and create gen.go files with --schema-only for VirtualMachineV2, VirtualMachineScanV2, VirtualMachineComponentV2, and VirtualMachineCVEV2. All types reuse the existing VirtualMachine SAC resource. FK references: Scan->VM, Component->Scan, CVE->VM+Component. Generated with the help of AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…le names The table names were previously hardcoded with --table flags that used plural forms (e.g., virtual_machines_v2), causing a mismatch with what the NamingStrategy derives from the storage type names. Removing --table lets the generator auto-derive table names consistently, which fixes cross-table reference resolution in the generated schema files. Partially generated by AI Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Feb 27, 2026
Contributor
|
Images are ready for the commit at f5992ce. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add VM v2 search categories, gen.go files, and generated schemas
Add four new search categories (VIRTUAL_MACHINES_V2, VIRTUAL_MACHINE_SCANS_V2,
VIRTUAL_MACHINE_COMPONENTS_V2, VIRTUAL_MACHINE_VULNERABILITIES_V2) to
search_service.proto and create gen.go files with --schema-only for
VirtualMachineV2, VirtualMachineScanV2, VirtualMachineComponentV2, and
VirtualMachineCVEV2. All types reuse the existing VirtualMachine SAC resource.
FK references: Scan->VM, Component->Scan, CVE->VM+Component.
Generated with the help of AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Remove --table flag from VM v2 gen.go files to use auto-generated table names
The table names were previously hardcoded with --table flags that used
plural forms (e.g., virtual_machines_v2), causing a mismatch with what
the NamingStrategy derives from the storage type names. Removing --table
lets the generator auto-derive table names consistently, which fixes
cross-table reference resolution in the generated schema files.
Partially generated by AI
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
regenerate
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!