ROX-33385: VM v2 DataStore#19241
Draft
dashrews78 wants to merge 2 commits intodashrews/vm-v2-store-33404from
Draft
ROX-33385: VM v2 DataStore#19241dashrews78 wants to merge 2 commits intodashrews/vm-v2-store-33404from
dashrews78 wants to merge 2 commits intodashrews/vm-v2-store-33404from
Conversation
Adds the public DataStore layer on top of the custom Store, following the V1 VM datastore pattern. The DataStore provides input validation, metrics, default sort ordering for search, and a singleton entry point. No risk scoring, ranking, or service wiring — those will come later. Prompt: implement DataStore interface, implementation, and singleton for VM v2 datastore layer. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Feb 27, 2026
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at f81a8ae. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dashrews/vm-v2-store-33404 #19241 +/- ##
==============================================================
- Coverage 49.60% 49.60% -0.01%
==============================================================
Files 2683 2683
Lines 202675 202675
==============================================================
- Hits 100539 100538 -1
Misses 94633 94633
- Partials 7503 7504 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add VM v2 DataStore interface, implementation, and singleton
Adds the public DataStore layer on top of the custom Store, following
the V1 VM datastore pattern. The DataStore provides input validation,
metrics, default sort ordering for search, and a singleton entry point.
No risk scoring, ranking, or service wiring — those will come later.
Prompt: implement DataStore interface, implementation, and singleton for
VM v2 datastore layer.
Partially generated by AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Generate mocks for VM v2 DataStore interface
Partially generated by AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!