ROX-33608: hook VM pipelines to V2 datastores#19441
Draft
dashrews78 wants to merge 3 commits intomasterfrom
Draft
ROX-33608: hook VM pipelines to V2 datastores#19441dashrews78 wants to merge 3 commits intomasterfrom
dashrews78 wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
829b61a to
b2cc202
Compare
9 tasks
Contributor
|
Images are ready for the commit at 45d1b7a. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19441 +/- ##
==========================================
+ Coverage 49.31% 49.37% +0.05%
==========================================
Files 2722 2724 +2
Lines 205171 205385 +214
==========================================
+ Hits 101190 101407 +217
+ Misses 96446 96444 -2
+ Partials 7535 7534 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
da73d8d to
14b0d81
Compare
When the feature flag is OFF, both virtualmachines and virtualmachineindex pipelines write to the v1 datastore (unchanged behavior). When ON, they write exclusively to the v2 datastore using normalized scan parts. Adds internaltostorage.VirtualMachineV2() conversion for sensor VM events, and v1tov2storage.ScanPartsFromV1Scan() to split embedded v1 scans into normalized v2 records (scan, components, CVEs) with CVSS/NVD extraction. The v2 datastore singleton returns nil when the flag is off, so the pipelines branch on whether the v2 store is non-nil rather than checking the flag directly. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace assert.Equal with protoassert.SlicesEqual when comparing proto message slices to satisfy the golangci-lint proto comparison check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
14b0d81 to
45d1b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the feature flag is OFF, both virtualmachines and virtualmachineindex
pipelines write to the v1 datastore (unchanged behavior). When ON, they
write exclusively to the v2 datastore using normalized scan parts.
Adds internaltostorage.VirtualMachineV2() conversion for sensor VM events,
and v1tov2storage.ScanPartsFromV1Scan() to split embedded v1 scans into
normalized v2 records (scan, components, CVEs) with CVSS/NVD extraction.
The v2 datastore singleton returns nil when the flag is off, so the
pipelines branch on whether the v2 store is non-nil rather than checking
the flag directly.
Partially generated by AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!